Skip to content

Consider current connection type in reconnect action in FRITZ!Box Tools#175129

Merged
frenck merged 1 commit into
devfrom
fritz/fix-reconnect-action
Jun 30, 2026
Merged

Consider current connection type in reconnect action in FRITZ!Box Tools#175129
frenck merged 1 commit into
devfrom
fritz/fix-reconnect-action

Conversation

@mib1185

@mib1185 mib1185 commented Jun 29, 2026

Copy link
Copy Markdown
Member

Proposed change

This takes the current connection type into account to perform the reconnect action. Performing this action returns an UPnPError (at least on my PPP connected device) instead of just some OK return code, so we need to ignore this

[...]
  File "/home/vscode/.local/ha-venv/lib/python3.14/site-packages/fritzconnection/core/fritzconnection.py", line 502, in reconnect
    self.call_action("WANPPPConnection1", "ForceTermination")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/workspaces/homeassistant-core/homeassistant/components/fritz/coordinator.py", line 111, in call_action
    return super().call_action(  # type: ignore[no-any-return]
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        service_name, action_name, arguments=arguments, **kwargs
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "/home/vscode/.local/ha-venv/lib/python3.14/site-packages/fritzconnection/core/fritzconnection.py", line 461, in call_action
    return self.soaper.execute(service, action_name, arguments)
           ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/vscode/.local/ha-venv/lib/python3.14/site-packages/fritzconnection/core/soaper.py", line 304, in execute
    return handle_response(response)
  File "/home/vscode/.local/ha-venv/lib/python3.14/site-packages/fritzconnection/core/soaper.py", line 286, in handle_response
    raise_fritzconnection_error(response)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
  File "/home/vscode/.local/ha-venv/lib/python3.14/site-packages/fritzconnection/core/soaper.py", line 192, in raise_fritzconnection_error
    raise exception(message)
fritzconnection.core.exceptions.FritzConnectionException: UPnPError: 
errorCode: 707
errorDescription: DisconnectInProgress

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

@mib1185 mib1185 added this to the 2026.7.0 milestone Jun 29, 2026
Copilot AI review requested due to automatic review settings June 29, 2026 15:37
@mib1185 mib1185 requested a review from chemelli74 as a code owner June 29, 2026 15:37
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: fritz small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage labels Jun 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of fritz can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign fritz Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@chemelli74 chemelli74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chemelli74

Copy link
Copy Markdown
Contributor

MAybe the PR title need a bit of tweak ;-)

@mib1185 mib1185 changed the title consider current connection type in reconnect action consider current connection type in reconnect action in FRITZ! Tools Jun 30, 2026
@mib1185 mib1185 changed the title consider current connection type in reconnect action in FRITZ! Tools Consider current connection type in reconnect action in FRITZ! Tools Jun 30, 2026
@mib1185 mib1185 changed the title Consider current connection type in reconnect action in FRITZ! Tools Consider current connection type in reconnect action in FRITZ!Box Tools Jun 30, 2026
@mib1185

mib1185 commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Thanks for approval Simone 😊 i've changed the title, what do you think?

@frenck frenck left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mib1185 👍

../Frenck

                       

Blogging my personal ramblings at frenck.dev

@frenck frenck merged commit 1c1d956 into dev Jun 30, 2026
32 of 33 checks passed
@frenck frenck deleted the fritz/fix-reconnect-action branch June 30, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix by-code-owner cherry-picked cla-signed has-tests integration: fritz Quality Scale: gold small-pr PRs with less than 30 lines. Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fritz!Box Tools - 'Button' Entities are not working

4 participants