Skip to content

Move service registration to async_setup in waze#175261

Merged
joostlek merged 1 commit into
home-assistant:devfrom
some-random-climber:waze
Jul 1, 2026
Merged

Move service registration to async_setup in waze#175261
joostlek merged 1 commit into
home-assistant:devfrom
some-random-climber:waze

Conversation

@some-random-climber

Copy link
Copy Markdown
Contributor

Proposed change

Move service registration to async_setup in waze.

Part of home-assistant/epics#65

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings July 1, 2026 11:14
@home-assistant

home-assistant Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hey there @eifinger, mind taking a look at this pull request as it has been labeled with an integration (waze_travel_time) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of waze_travel_time can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign waze_travel_time Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the waze_travel_time integration to register its get_travel_times service in async_setup instead of async_setup_entry, as part of the epic to make services available for automation validation regardless of config-entry load state (home-assistant/epics#65). The service logic is extracted into a dedicated services.py module following the established Home Assistant pattern, and the home-assistant-service-registered-in-setup-entry pylint suppression is removed.

Changes:

  • Added a new services.py containing the service schema, handler (async_get_travel_times_service), and a @callback async_setup_services registration helper.
  • Added async_setup and CONFIG_SCHEMA = cv.config_entry_only_config_schema(DOMAIN) to __init__.py, invoking async_setup_services, and removed the in-entry service registration plus now-unused imports.

I verified that the service handler is self-contained (it builds its own client from service.data, so it does not depend on a loaded config entry), all removed imports are no longer referenced in __init__.py, all services.py imports resolve to existing definitions, and the existing tests in test_init.py still exercise the service via config-entry setup which triggers async_setup.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/components/waze_travel_time/services.py New module holding the service schema, handler, and async_setup_services registration helper.
homeassistant/components/waze_travel_time/__init__.py Adds async_setup/CONFIG_SCHEMA, delegates service registration to services.py, and removes the in-entry registration and unused imports.

@joostlek joostlek merged commit b6578e9 into home-assistant:dev Jul 1, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move service registration to async_setup in waze_travel_time

3 participants