Skip to content

Google Photos refactor OAuth exceptions#175271

Merged
joostlek merged 1 commit into
home-assistant:devfrom
erwindouna:google_photos_refactor_oauth_exceptions
Jul 1, 2026
Merged

Google Photos refactor OAuth exceptions#175271
joostlek merged 1 commit into
home-assistant:devfrom
erwindouna:google_photos_refactor_oauth_exceptions

Conversation

@erwindouna

@erwindouna erwindouna commented Jul 1, 2026

Copy link
Copy Markdown
Member

Breaking change

None.

Proposed change

Refactor Google Photos setup to handle OAuth token refresh failures using the OAuth-specific exceptions raised by the shared OAuth config entry helper.

This keeps reauth failures mapped to ConfigEntryAuthFailed and transient OAuth/client errors mapped to ConfigEntryNotReady, without inspecting raw aiohttp.ClientResponseError status codes in the integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings July 1, 2026 12:29
@erwindouna erwindouna requested a review from allenporter as a code owner July 1, 2026 12:29
@home-assistant

home-assistant Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration (google_photos) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_photos can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign google_photos Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Google Photos integration’s config entry setup to rely on the shared OAuth helper’s dedicated token refresh exception types, instead of inspecting aiohttp.ClientResponseError HTTP status codes directly.

Changes:

  • Replace ClientResponseError status-splitting with OAuth2TokenRequestReauthErrorConfigEntryAuthFailed.
  • Treat remaining OAuth token request failures (including transient) and aiohttp.ClientError as retryable via ConfigEntryNotReady.
  • Remove the unused ClientResponseError import.

@joostlek joostlek merged commit c7ba474 into home-assistant:dev Jul 1, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Photos: refactor to use new OAuth exceptions

4 participants