Google Photos refactor OAuth exceptions#175271
Merged
joostlek merged 1 commit intoJul 1, 2026
Merged
Conversation
Contributor
|
Hey there @allenporter, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Google Photos integration’s config entry setup to rely on the shared OAuth helper’s dedicated token refresh exception types, instead of inspecting aiohttp.ClientResponseError HTTP status codes directly.
Changes:
- Replace
ClientResponseErrorstatus-splitting withOAuth2TokenRequestReauthError→ConfigEntryAuthFailed. - Treat remaining OAuth token request failures (including transient) and
aiohttp.ClientErroras retryable viaConfigEntryNotReady. - Remove the unused
ClientResponseErrorimport.
joostlek
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
None.
Proposed change
Refactor Google Photos setup to handle OAuth token refresh failures using the OAuth-specific exceptions raised by the shared OAuth config entry helper.
This keeps reauth failures mapped to
ConfigEntryAuthFailedand transient OAuth/client errors mapped toConfigEntryNotReady, without inspecting rawaiohttp.ClientResponseErrorstatus codes in the integration.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: