Switchbot_cloud: fixed cloud hook error#175336
Merged
joostlek merged 1 commit intoJul 2, 2026
Merged
Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: switchbot_cloud
small-pr
Contributor
|
Hey there @SeraphicRav, @laurence-presland, @Gigatrappeur, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes SwitchBot Cloud webhook setup for Home Assistant Cloud (Nabu Casa) users by using the Cloud helper that reuses an existing cloudhook when available, avoiding failures when a hook already exists.
Changes:
- Replace “delete then create” cloudhook flow with
cloud.async_get_or_create_cloudhook(...)in the SwitchBot Cloud integration. - Update SwitchBot Cloud integration tests to patch
async_get_or_create_cloudhookinstead ofasync_create_cloudhook.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/switchbot_cloud/__init__.py |
Uses async_get_or_create_cloudhook to obtain a cloudhook URL and persist it on the config entry. |
tests/components/switchbot_cloud/test_init.py |
Adjusts mocks/patch targets to match the new cloudhook helper used by the integration. |
Comments suppressed due to low confidence (1)
homeassistant/components/switchbot_cloud/init.py:531
- Update the debug log to avoid claiming the cloudhook was newly created when
async_get_or_create_cloudhookmay return an existing hook.
cloudhook_url = await cloud.async_get_or_create_cloudhook(hass, webhook_id)
hass.config_entries.async_update_entry(
entry, data={**entry.data, CONF_CLOUDHOOK_URL: cloudhook_url}
)
_LOGGER.debug("Created SwitchBot Cloud cloudhook: %s", cloudhook_url)
return cloudhook_url
joostlek
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This issue currently appears to affect only users who have set up HA Cloud webhooks.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: