Fixed development mode for http component not working correctly#46
Closed
jamespcole wants to merge 1 commit into
Closed
Fixed development mode for http component not working correctly#46jamespcole wants to merge 1 commit into
jamespcole wants to merge 1 commit into
Conversation
When using the new YAML format for the config file the development mode for the http component was not working correctly because when the YAML is parsed the "development" config variable is an int and not a string so the comparison always failed. It worked fine with the old config file format so I have converted the config value to a string to keep backwards compatibility rather than just change the compared value to an int. I have tested with both the old and new versions of the config files. This one drove me nuts, took a while to track down, I hope I save someone else some time.
Member
|
I already made this change in the dev branch ☺ |
Contributor
Author
|
Whoops, I guess I should have checked dev first, I did a pull a couple of days ago but that must have been before your update. Also I'll make sure I make pull requests to dev in the future. |
Member
|
No problem :-) On Sat, Mar 7, 2015 at 5:16 AM, James Cole notifications@github.com wrote:
+1 858 380 9709 ⋅ PaulusSchoutsen.nl |
geoffoxholm
pushed a commit
to geoffoxholm/ha_core
that referenced
this pull request
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the new YAML format for the config file the development mode for the http component was not working correctly because when the YAML is parsed the "development" config variable is an int and not a string so the comparison always failed. It worked fine with the old config file format so I have converted the config value to a string to keep backwards compatibility rather than just change the compared value to an int. I have tested with both the old and new versions of the config files. This one drove me nuts, took a while to track down, I hope I save someone else some time.