Skip to content

Fixed development mode for http component not working correctly#46

Closed
jamespcole wants to merge 1 commit into
home-assistant:masterfrom
jamespcole:patch-1
Closed

Fixed development mode for http component not working correctly#46
jamespcole wants to merge 1 commit into
home-assistant:masterfrom
jamespcole:patch-1

Conversation

@jamespcole

Copy link
Copy Markdown
Contributor

When using the new YAML format for the config file the development mode for the http component was not working correctly because when the YAML is parsed the "development" config variable is an int and not a string so the comparison always failed. It worked fine with the old config file format so I have converted the config value to a string to keep backwards compatibility rather than just change the compared value to an int. I have tested with both the old and new versions of the config files. This one drove me nuts, took a while to track down, I hope I save someone else some time.

When using the new YAML format for the config file the development mode for the http component was not working correctly because when the YAML is parsed the "development" config variable is an int and not a string so the comparison always failed.  It worked fine with the old config file format so I have converted the config value to a string to keep backwards compatibility rather than just change the compared value to an int.  I have tested with both the old and new versions of the config files.  This one drove me nuts, took a while to track down, I hope I save someone else some time.
@balloob

balloob commented Mar 7, 2015

Copy link
Copy Markdown
Member

I already made this change in the dev branch ☺
ba9f29a
For future pull requests please target the dev branch.

@jamespcole

Copy link
Copy Markdown
Contributor Author

Whoops, I guess I should have checked dev first, I did a pull a couple of days ago but that must have been before your update. Also I'll make sure I make pull requests to dev in the future.

@jamespcole jamespcole closed this Mar 7, 2015
@balloob

balloob commented Mar 7, 2015

Copy link
Copy Markdown
Member

No problem :-)

On Sat, Mar 7, 2015 at 5:16 AM, James Cole notifications@github.com wrote:

Whoops, I guess I should have checked dev first, I did a pull a couple of
days ago but that must have been before your update. Also I'll make sure I
make pull requests to dev in the future.


Reply to this email directly or view it on GitHub
#46 (comment).

+1 858 380 9709 ⋅ PaulusSchoutsen.nl
It's nice to be important but it's more important to be nice.

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants