distro: alpine: consolidate EXTRA_INDEX_URL#361
Conversation
eshattow
commented
Apr 22, 2026
eshattow
commented
- add required EXTRA_INDEX_URL docker build ARG to alpine distro Dockerfile and workflow
- alpine docker image refers corresponding pip and uv env variables to EXTRA_INDEX_URL as built
- drop now-redundant config file definition of pip extra-index-url from alpine rootfs
|
Please review carefully before merging, I am not sure how this will interact with S6. The objective is have control of the build-time extra wheels index url configuration within the workflow instead of spread out over several files. |
eshattow
force-pushed
the
consolidate-alpine-extra-index-url
branch
from
840f11d to
bd6bc2e
Compare
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
Generally LGTM, but there are some fundamental issues of the current validation and passing of the arg, see below.
I don't know what interactions with S6 it could have - do you have some particular in mind?
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
eshattow
force-pushed
the
consolidate-alpine-extra-index-url
branch
2 times, most recently
from
ae68de7 to
148d60d
Compare
* Introduce ARG EXTRA_INDEX_URL to alpine docker build and import in final alpine distro output image as PIP_EXTRA_INDEX_URL and UV_EXTRA_INDEX_URL runtime environment variables * Remove now-redundant config file definition of extra-index-url from alpine docker rootfs * No change to https://wheels.home-assistant.io/musllinux-index/ default in final alpine distro output image, may override as-built value in the usual way setting build-args from build workflow
eshattow
force-pushed
the
consolidate-alpine-extra-index-url
branch
from
148d60d to
4d8c99a
Compare
None, just my ignorance as I have no experience with what "S6" is and the previously existing comment says that these environment variables exist to support it. The only thought I have about how this could break is if some user of this depends on being able to provide both an extra-wheels-index and an env variable for this value simultaneously, which although I find unlikely or not the situation as-is, I want to be sure this is not going to break for users. Assuming you're okay with the requested changes as implemented, I have no additional concerns. Thanks for reviewing! |
sairon
left a comment
sairon
left a comment
There was a problem hiding this comment.
Looks good now, image only has two layers and the environment is set correctly:
"Config": {
"Env": [
"PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
"LANG=C.UTF-8",
"S6_BEHAVIOUR_IF_STAGE2_FAILS=2",
"S6_CMD_WAIT_FOR_SERVICES_MAXTIME=0",
"S6_CMD_WAIT_FOR_SERVICES=1",
"S6_SERVICES_READYTIME=50",
"PIP_EXTRA_INDEX_URL=https://wheels.home-assistant.io/musllinux-index/",
"UV_EXTRA_INDEX_URL=https://wheels.home-assistant.io/musllinux-index/"
],
...
Thanks!
2 participants
