Redesign thread credentials sharing#2478
Merged
Merged
Conversation
bgoncal
force-pushed
the
thread-credentials-redesign
branch
from
3ae2472 to
ceebbf8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2478 +/- ##
==========================================
- Coverage 28.21% 28.19% -0.03%
==========================================
Files 285 286 +1
Lines 30759 30789 +30
==========================================
+ Hits 8680 8682 +2
- Misses 22079 22107 +28 ☔ View full report in Codecov by Sentry. |
zacwest
approved these changes
Dec 12, 2023
Member
zacwest
left a comment
zacwest
left a comment
There was a problem hiding this comment.
can you change the modal presentation style so the darkening background doesn't move upwards?
bgoncal
force-pushed
the
thread-credentials-redesign
branch
from
ceebbf8 to
314f20c
Compare
Member
Author
RPReplay_Final1702414850.MP4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
RPReplay_Final1702405177.MP4
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes