Run download provisioning profiles before importing them#3849
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Fastlane provisioning profile download process by replacing platform-specific commands with simplified unified commands and updating related CI configuration.
- Simplified the
download_provisioning_profileslane by removing the platform loop and using unifiedsighcommands - Added environment variable setup for authentication credentials in the download process
- Updated CI workflow to include necessary secrets for the provisioning profile operations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| fastlane/Fastfile | Simplified provisioning profile download logic and removed unused SIGH_USERNAME variable |
| HomeAssistant.xcodeproj/project.pbxproj | Added project references for .github and fastlane directories |
| .github/workflows/ci.yml | Added required environment variables for App Store Connect authentication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3849 +/- ##
==========================================
+ Coverage 44.72% 45.84% +1.12%
==========================================
Files 232 236 +4
Lines 13911 14153 +242
==========================================
+ Hits 6221 6488 +267
+ Misses 7690 7665 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bgoncal
added a commit
that referenced
this pull request
Sep 24, 2025
…)" This reverts commit 664938a.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes