Add haptic feedback to todo list widget buttons#4355
Conversation
Co-authored-by: bgoncal <5808343+bgoncal@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds haptic feedback to todo list widget buttons, completing the haptic coverage introduced in PR #4354. The implementation uses the established AppIntentHaptics.notify() method that triggers system sound 1520 (iOS "Peek" sound) for subtle haptic and audio feedback. Both intents properly trigger haptics before the action executes, following the established timing pattern.
Changes:
- Added haptic feedback to the todo list item completion button via an optional
hapticConfirmationparameter with defaulttrue - Added unconditional haptic feedback to the todo list refresh button
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Sources/Extensions/Widgets/TodoList/TodoItemCompleteAppIntent.swift |
Adds optional hapticConfirmation parameter (default: true) with proper initialization in both constructors and conditional haptic call before completing todo items |
Sources/Extensions/Widgets/TodoList/TodoListRefreshAppIntent.swift |
Adds unconditional AppIntentHaptics.notify() call before reloading widget timelines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4355 +/- ##
=======================================
Coverage ? 42.99%
=======================================
Files ? 262
Lines ? 15152
Branches ? 0
=======================================
Hits ? 6515
Misses ? 8637
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Adds haptic feedback (system sound 1520 "Peek") to todo list widget buttons, completing the haptic coverage introduced in #4354. Previously, only custom widgets and automations had haptic feedback; todo list complete and refresh buttons were missing.
Changes:
hapticConfirmationparameter (default:true) with conditionalAppIntentHaptics.notify()callAppIntentHaptics.notify()callBoth follow established patterns: widget buttons provide immediate haptic feedback on press (not on completion), and widget-context intents default haptics to enabled while shortcut-context intents make them optional.
Screenshots
N/A - Haptic feedback only (audio/tactile), no visual changes.
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
Widget buttons coverage:
TodoItemCompleteAppIntentTodoListRefreshAppIntentOriginal prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.