Bind delayed instruction hide to SwiftUI view lifecycle

[llkenny]

Summary

Problem
CamerasRoomView hides instructions with a delayed Task started from onAppear. The task is not lifecycle-bound and can still mutate showInstructions after the view disappears.

Change
Move the delayed hide logic to SwiftUI .task so it is automatically cancelled when the view leaves the hierarchy. Keep behavior unchanged (instructions still hide after ~3s).

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

Verification
Built the app target locally. Relying on CI (GitHub Actions) to run tests/build.

[home-assistant]

Hi @llkenny

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[Copilot]

Pull request overview

This PR fixes a lifecycle bug in CamerasRoomView where a delayed task to hide UI instructions could continue to mutate state after the view disappears. The change migrates from .onAppear with a manual Task to the SwiftUI .task modifier, which automatically cancels the task when the view leaves the hierarchy.

Changes:

• Replaced .onAppear with .task modifier for lifecycle-bound task management
• Added early return guard to check if instructions are already hidden
• Wrapped state mutation in MainActor.run for explicit main thread execution

Comments suppressed due to low confidence (1)

Sources/App/Cameras/CameraList/CamerasRoomView.swift:87

• The MainActor.run wrapper is unnecessary here. SwiftUI @State properties are already @MainActor isolated, and updates to them from within a .task modifier are automatically executed on the main actor. You can directly update showInstructions within the withAnimation block.

                await MainActor.run {
                    withAnimation {
                        showInstructions = false
                    }
                }

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@5c85ffc). Learn more about missing BASE report.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4382   +/-   ##
=======================================
  Coverage        ?   42.97%           
=======================================
  Files           ?      262           
  Lines           ?    15182           
  Branches        ?        0           
=======================================
  Hits            ?     6524           
  Misses          ?     8658           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Cla is signed already