Merged
Conversation
github-actions
Bot
requested review from
Copilot
and removed request for
Copilot
zacwest
force-pushed
the
create-pull-request/download_strings
branch
from
63c66f0 to
55703b0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the app’s localization resources to include new user-facing strings (notably for client-certificate/mTLS flows and an “experimental feature” badge), while also adjusting a few existing translations.
Changes:
- Add new localization keys for client-certificate (mTLS) onboarding/errors/settings and experimental badge messaging across many locales.
- Reorganize/normalize placement of some keys in
en.lproj/Localizable.strings(removing duplicate entries at the bottom and keeping the canonical entries earlier). - Update a handful of existing translations (notably Russian widgets/app-intents strings and Welsh frontend panel names).
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/App/Resources/zh-Hant.lproj/Localizable.strings | Adds new mTLS + experimental badge strings (currently English in this locale). |
| Sources/App/Resources/zh-Hans.lproj/Localizable.strings | Adds new mTLS + experimental badge strings (currently English in this locale). |
| Sources/App/Resources/vi.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/uk.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/tr.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/sv.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/sl.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/ru.lproj/Localizable.strings | Adds new mTLS + experimental badge strings; updates several widget-related translations. |
| Sources/App/Resources/ru.lproj/Intents.strings | Updates Russian App Intents strings for “Assist in app”. |
| Sources/App/Resources/pt-BR.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/pl-PL.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/nl.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/nb.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/ml.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/ko-KR.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/ja.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/it.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/id.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/hu.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/he.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/fr.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/fi.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/et.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/es.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/es-MX.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/es-ES.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/en.lproj/Localizable.strings | Adds new mTLS + experimental badge strings; removes duplicated entries from the end and keeps canonical entries earlier. |
| Sources/App/Resources/en-GB.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/el.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/de.lproj/Localizable.strings | Adds new mTLS + experimental badge strings (currently English in this locale). |
| Sources/App/Resources/da.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/cy-GB.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/cy-GB.lproj/Frontend.strings | Updates Welsh frontend panel translations (e.g., Calendar/Profile). |
| Sources/App/Resources/cs.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/ca-ES.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
| Sources/App/Resources/bg.lproj/Localizable.strings | Adds new mTLS + experimental badge strings. |
Comment on lines
+321
to
+323
| "experimental.badge.body" = "This is an experimental feature, you may experience unexpected behavior, please report any issues you may encounter."; | ||
| "experimental.badge.report_issue_button.title" = "Report issue"; | ||
| "experimental.badge.title" = "Experimental feature"; |
There was a problem hiding this comment.
The newly added “experimental feature” badge strings are still English in the Simplified Chinese localization. Please translate these values (body/title/button) to keep the locale consistent.
Comment on lines
+314
to
+318
| "error.client_certificate.flow_cancelled" = "Client Certificate Authentication required.\ | ||
| \ | ||
| This server requires a client certificate (mTLS) but the operation was cancelled."; | ||
| "error.client_certificate.flow_failed" = "Client Certificate Authentication failed.\ | ||
| \ |
There was a problem hiding this comment.
These newly added client-certificate (mTLS) error strings are still in English in the Traditional Chinese localization. If this PR is intended to update localized strings, please provide zh-Hant translations for these values (and the other new client-certificate keys added in this file) so users don’t see untranslated UI.
Comment on lines
+321
to
+323
| "experimental.badge.body" = "This is an experimental feature, you may experience unexpected behavior, please report any issues you may encounter."; | ||
| "experimental.badge.report_issue_button.title" = "Report issue"; | ||
| "experimental.badge.title" = "Experimental feature"; |
There was a problem hiding this comment.
The newly added “experimental feature” badge strings are still English in the Traditional Chinese localization. Please translate these values (body/title/button) to keep the locale consistent.
Comment on lines
+314
to
+317
| "error.client_certificate.flow_cancelled" = "Client Certificate Authentication required.\ | ||
| \ | ||
| This server requires a client certificate (mTLS) but the operation was cancelled."; | ||
| "error.client_certificate.flow_failed" = "Client Certificate Authentication failed.\ |
There was a problem hiding this comment.
These newly added client-certificate (mTLS) error strings are still in English in the German localization. If this PR is meant to update localizations, please provide German translations for these values (and the other new client-certificate keys added in this file) so users don’t see untranslated UI.
Suggested change
| "error.client_certificate.flow_cancelled" = "Client Certificate Authentication required.\ | |
| \ | |
| This server requires a client certificate (mTLS) but the operation was cancelled."; | |
| "error.client_certificate.flow_failed" = "Client Certificate Authentication failed.\ | |
| "error.client_certificate.flow_cancelled" = "Client-Zertifikatsauthentifizierung erforderlich.\ | |
| \ | |
| Dieser Server erfordert ein Client-Zertifikat (mTLS), aber der Vorgang wurde abgebrochen."; | |
| "error.client_certificate.flow_failed" = "Client-Zertifikatsauthentifizierung fehlgeschlagen.\ |
Comment on lines
+321
to
+323
| "experimental.badge.body" = "This is an experimental feature, you may experience unexpected behavior, please report any issues you may encounter."; | ||
| "experimental.badge.report_issue_button.title" = "Report issue"; | ||
| "experimental.badge.title" = "Experimental feature"; |
There was a problem hiding this comment.
The newly added “experimental feature” badge strings are still English in the German localization. Please translate these values (body/title/button) to keep the locale consistent.
Suggested change
| "experimental.badge.body" = "This is an experimental feature, you may experience unexpected behavior, please report any issues you may encounter."; | |
| "experimental.badge.report_issue_button.title" = "Report issue"; | |
| "experimental.badge.title" = "Experimental feature"; | |
| "experimental.badge.body" = "Dies ist eine experimentelle Funktion. Es kann zu unerwartetem Verhalten kommen. Bitte melde alle Probleme, auf die du stößt."; | |
| "experimental.badge.report_issue_button.title" = "Problem melden"; | |
| "experimental.badge.title" = "Experimentelle Funktion"; |
Comment on lines
+314
to
+318
| "error.client_certificate.flow_cancelled" = "Client Certificate Authentication required.\ | ||
| \ | ||
| This server requires a client certificate (mTLS) but the operation was cancelled."; | ||
| "error.client_certificate.flow_failed" = "Client Certificate Authentication failed.\ | ||
| \ |
There was a problem hiding this comment.
These newly added client-certificate (mTLS) error strings are still in English in the Simplified Chinese localization. If this PR is intended to update localized strings, please provide zh-Hans translations for these values (and the other new client-certificate keys added in this file) so users don’t see untranslated UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically created by zacwest.