Remove dead HomeAssistantLogoView.xib#4576
Merged
Merged
Conversation
The XIB declares a custom view class `HomeAssistantLogoView` from the HomeAssistant module, but no Swift file with that class name exists and nothing loads the nib (no `UINib(nibName:)` or `Bundle.loadNibNamed` call references it). Pure dead resource. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused/dead Settings XIB (HomeAssistantLogoView.xib) and its associated Xcode project references, reducing stale resources in the iOS app target.
Changes:
- Delete
Sources/App/Settings/HomeAssistantLogoView.xib. - Remove the corresponding
PBXBuildFile/PBXFileReference/ group entry / Resources build phase entries fromproject.pbxproj.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/App/Settings/HomeAssistantLogoView.xib | Deleted unused XIB resource that had no code/class/runtime references. |
| HomeAssistant.xcodeproj/project.pbxproj | Removed all project/resource build phase references to the deleted XIB. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4576 +/- ##
=======================================
Coverage ? 43.24%
=======================================
Files ? 275
Lines ? 16700
Branches ? 0
=======================================
Hits ? 7222
Misses ? 9478
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
bgoncal
added a commit
that referenced
this pull request
Apr 29, 2026
## Summary Four pieces of dead code with zero inbound references in `Sources/` or `Tests/`. Verified by `git grep` against `origin/main` after PRs #4561–#4564 + #4576 landed. | Item | Lines | Status | |---|---|---| | `Sources/App/Utilities/ScaledFont.swift` | 115 | Third-party Keith Harrison dynamic-type utility, never referenced | | `Sources/App/Utilities/VoiceShortcutsManager.swift` | 35 | `public class` wrapping `INVoiceShortcut` lookup, never instantiated | | `Sources/App/Utilities/InputAccessoryView.swift` | 37 | Custom `UIView` subclass, never instantiated, no XIB/storyboard `customClass` reference | | `EntitiesStateSubscription` protocol in `Sources/App/Scenes/CarPlaySceneDelegate.swift` | 5 | Declares `subscribe()`/`unsubscribe()` with no conformers and no callers | **204 lines deleted across 5 files** (3 source deletions, 1 partial edit, 1 `project.pbxproj` cleanup). No behavior change. ## Verification - `git grep` for each type name across `Sources/` and `Tests/` returns only the file itself + the `project.pbxproj` entry. - Searched for indirect references: XIB `customClass="X"`, `NSStringFromClass`, `@objc` selectors, string-based UIKit nib loaders. None found. - `plutil -lint` confirms `project.pbxproj` parses. - `swiftformat` + `rubocop -a` produce zero changes. ## Test plan - [ ] CI build + tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sources/App/Settings/HomeAssistantLogoView.xibis dead — the XIB declares a custom view classHomeAssistantLogoViewfrom theHomeAssistantmodule, but:HomeAssistantLogoView.swiftexists anywhere in the projectUINib(nibName: "HomeAssistantLogoView", noBundle.loadNibNamed("HomeAssistantLogoView")project.pbxprojentriesRemoves the XIB and its 4
project.pbxprojreferences.Test plan
🤖 Generated with Claude Code