Skip to content

Update Localized Strings#4580

Merged
bgoncal merged 1 commit into
mainfrom
create-pull-request/download_strings
Apr 30, 2026
Merged

Update Localized Strings#4580
bgoncal merged 1 commit into
mainfrom
create-pull-request/download_strings

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Apr 29, 2026

Automatically created by zacwest.

@github-actions github-actions Bot requested review from Copilot and removed request for Copilot April 29, 2026 06:48
@zacwest zacwest force-pushed the create-pull-request/download_strings branch from 2d9f38c to 941d48e Compare April 30, 2026 06:50
Copilot AI review requested due to automatic review settings April 30, 2026 06:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused localization key across multiple locales and updates one Greek NFC string translation, keeping the app’s localized string resources in sync with the active string catalog used by the codebase.

Changes:

  • Removed the settings.connection_section.all_servers string from many Localizable.strings locale files.
  • Updated the Greek translation for nfc.detail.duplicate.

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Sources/App/Resources/zh-Hant.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/zh-Hans.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/vi.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/uk.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/tr.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/sv.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/sl.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/ru.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/pt-BR.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/pl-PL.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/nl.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/nb.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/ml.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/ko-KR.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/ja.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/it.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/id.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/hu.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/he.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/fr.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/fi.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/et.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/es.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/es-MX.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/es-ES.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/en-GB.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/el.lproj/Localizable.strings Update nfc.detail.duplicate translation; remove settings.connection_section.all_servers entry.
Sources/App/Resources/de.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/da.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/cy-GB.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/cs.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/ca-ES.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.
Sources/App/Resources/bg.lproj/Localizable.strings Remove settings.connection_section.all_servers entry.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4fdc069). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4580   +/-   ##
=======================================
  Coverage        ?   43.24%           
=======================================
  Files           ?      275           
  Lines           ?    16700           
  Branches        ?        0           
=======================================
  Hits            ?     7222           
  Misses          ?     9478           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bgoncal bgoncal merged commit 75aab68 into main Apr 30, 2026
18 of 19 checks passed
@bgoncal bgoncal deleted the create-pull-request/download_strings branch April 30, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants