[mTLS] Use session-level auth handling and avoid main queue#4591
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts onboarding connectivity checks to handle mTLS/server-trust challenges at the session delegate level and removes the URLSession delegate’s main-queue pinning to avoid TLS handshake stalls during UI transitions.
Changes:
- Create the URLSession with
delegateQueue: nilinstead of.main. - Refactor auth-challenge handling into a shared helper and add a session-level
urlSession(_:didReceive:completionHandler:)handler. - Dispatch alert presentation to the main queue.
- Revert delegateQueue back to `.main`. Reverts the speculative queue switch that introduced data-race risk on the per-task dictionaries and pushed UIKit alert configuration onto the URLSession's background delegate queue. - Drop the per-task `[Int: ...]` dictionaries in favour of a single in-flight resolver and three plain `Bool` flags, reset at the top of every `performConnection`. Eliminates the latent stale-entry bug when the same step instance handles multiple `perform(point:)` calls. - The session-level challenge handler now reads `currentResolver` directly, so it can no longer pick a leftover entry from a previous run. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4591 +/- ##
=======================================
Coverage ? 43.24%
=======================================
Files ? 275
Lines ? 16700
Branches ? 0
=======================================
Hits ? 7222
Misses ? 9478
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes