Skip to content

GitHub: fix issues/pr searching#8

Merged
xu-cheng merged 1 commit intoHomebrew:masterfrom
xu-cheng:github-issues-pr
Apr 3, 2016
Merged

GitHub: fix issues/pr searching#8
xu-cheng merged 1 commit intoHomebrew:masterfrom
xu-cheng:github-issues-pr

Conversation

@xu-cheng
Copy link
Copy Markdown
Contributor

@xu-cheng xu-cheng commented Apr 3, 2016

Closes #6.

Comment thread Library/Homebrew/utils.rb Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this is invoked on a failed search for a formula (at least judging from the referenced issue), so searching in Homebrew/homebrew-core seems to make more sense. Homebrew/brew is not going to yield any sensible results for searching involving formula names, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right.

@xu-cheng xu-cheng merged commit bc19a47 into Homebrew:master Apr 3, 2016
@xu-cheng xu-cheng deleted the github-issues-pr branch April 3, 2016 18:00
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants