Skip to content

Add helpful error message when attempting to run brew cask #12708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rylan12 merged 4 commits into from
Feb 11, 2022
Merged

Add helpful error message when attempting to run brew cask #12708

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f18cbd2
Add helpful error message when attempting to run `brew cask`
phoenixeliot Jan 11, 2022
9e2c591
Simplify 'brew cask' check
phoenixeliot Feb 8, 2022
7a5eb3d
Fix rubocop warning
phoenixeliot Feb 8, 2022
0c52084
Improve message
Rylan12 Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Library/Homebrew/brew.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ class MissingEnvironmentVariables < RuntimeError; end
possible_tap = Tap.fetch(possible_tap.first) if possible_tap

if !possible_tap || possible_tap.installed? || Tap.untapped_official_taps.include?(possible_tap.name)
# Check for cask explicitly because it's very common in old guides
odie "`brew cask` is no longer a `brew` command. Use `brew <command> --cask` instead." if cmd == "cask"
odie "Unknown command: #{cmd}"
end

Expand Down