Skip to content

GitHub: fix issues/pr searching #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xu-cheng merged 1 commit into from
Apr 3, 2016
Merged

GitHub: fix issues/pr searching #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Library/Homebrew/exceptions.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ def issues
end

def fetch_issues
GitHub.issues_for_formula(formula.name)
GitHub.issues_for_formula(formula.name, :tap => formula.tap)
rescue GitHub::RateLimitExceededError => e
opoo e.message
[]
Expand Down
7 changes: 4 additions & 3 deletions Library/Homebrew/utils.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ def build_query_string(query, qualifiers)

def build_search_qualifier_string(qualifiers)
{
:repo => "Homebrew/homebrew",
:repo => "Homebrew/homebrew-core",
:in => "title"
}.update(qualifiers).map do |qualifier, value|
"#{qualifier}:#{value}"
Expand All @@ -679,8 +679,9 @@ def uri_escape(query)
end
end

def issues_for_formula(name)
issues_matching(name, :state => "open")
def issues_for_formula(name, options = {})
tap = options[:tap] || CoreTap.instance
issues_matching(name, :state => "open", :repo => "#{tap.user}/homebrew-#{tap.repo}")
end

def print_pull_requests_matching(query)
Expand Down