-
-
Notifications
You must be signed in to change notification settings - Fork 876
Add peertube #5065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add peertube #5065
Conversation
49e18ab
to
508bd19
Compare
b2ef015
to
ea63eb0
Compare
working screenshot: |
Thanks for the contribution! Tested and confirmed working on Chrome + Edge. Firefox confirmed based on above screenshot. @larsjohnsen Do we need the migration trigger as this is a new module? Related to #5049, https://peervideo.net/about/peertube looks like the best URL for that PR, the multiple domains are covered by it. |
Would be nice to add a setting in the UI for adding new domain for Peertube. |
ea63eb0
to
8bbbba1
Compare
Leaved untouched migrate.js and expand only with videos. |
@kevinji thanks |
any reason this uses a domain whitelist? |
@SoniEx2 |
Maybe you could check for the Peertube meta tag instead of hardcoding an instance list? However it is not released yet. |
it's actually possible to detect the URL layouts of peertube and the peertube API. altho the tag does make it easier I guess. |
@Nutomic That would require loading all links, correct? I think that would be infeasible, both due to bandwidth and privacy concerns. |
Hm. p2p-sourced link data? |
This may be a little off-topic, but shouldn't the og-tags always be loaded for unkown urls? After all |
ec0f8cf
to
a7c7a74
Compare
that pissed me off with youtube-dl and it pisses me off here too. altho youtube-dl downloads the full page anyway so they don't have an excuse for it. does RES not? |
Thanks, @aliceinwire! |
would be nice to use a peertube instance list like https://fediverse.network/about |
I don't think that handles non-federating instances |
Adding peertube