Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Drop Support for Python 3.5 and 3.6 in Beeline #233

Merged
emilyashley merged 5 commits into from
Sep 9, 2022
Merged

Drop Support for Python 3.5 and 3.6 in Beeline #233

emilyashley merged 5 commits into from
Sep 9, 2022

Conversation

@emilyashley
Copy link
Contributor

@emilyashley emilyashley commented Sep 6, 2022 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Bump version of Python required to 3.7 or higher
  • Resolve dependencies
  • Follow updated pylint expectations, including using f strings instead of .format()
  • The u prefix for strings is no longer necessary, since Python 3.0 strings are Unicode by default.
  • with upgrades, we needed to switch from patching current_app to app_context() when testing flask middleware
  • ensure Flask example app still works, had to manually resolve a transient dependency due to ImportError: cannot import name 'soft_unicode' from 'markupsafe'
  • note: unfortunately, the hello world example was broken when I arrived, should make follow up ticket!

@emilyashley
[examples] slightly downgrade markupsafe to avoid breaking changes
9edd198 
ImportError: cannot import name 'soft_unicode' from 'markupsafe'
@emilyashley
The u prefix for strings is no longer necessary
47e8e5a 
These prefixes were necessary in Python 2 to indicate a string was Unicode, but since Python 3.0 strings are Unicode by default.
@emilyashley emilyashley marked this pull request as ready for review September 7, 2022 22:17
@emilyashley emilyashley requested review from a team and JamieDanielson September 7, 2022 22:17
@emilyashley emilyashley changed the title [fafo] python update Drop Support for Python 3.5 and 3.6 in Beeline Sep 7, 2022
MikeGoldsmith
MikeGoldsmith approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @emilyashley 👍🏻

Please can you add labels to the PR to show it's type (maintenance, enhancement, bug) and expected release verion impact (patch, minor, major) 😄

@emilyashley emilyashley merged commit 51d30f6 into main Sep 9, 2022
@emilyashley emilyashley deleted the emash-python-update branch September 9, 2022 17:40
@emilyashley emilyashley added the type: maintenance The necessary chores to keep the dust off. label Sep 9, 2022
@emilyashley emilyashley mentioned this pull request Sep 9, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JamieDanielson JamieDanielson Awaiting requested review from JamieDanielson

@kentquirk kentquirk Awaiting requested review from kentquirk

1 more reviewer

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emilyashley emilyashley

Labels

type: maintenance The necessary chores to keep the dust off.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.5, 3.6

3 participants

@emilyashley @MikeGoldsmith