fix(vercel): fix handle() return type for Next.js 15 App router#4881
Closed
mddanishh18 wants to merge 2 commits intohonojs:mainfrom
Closed
fix(vercel): fix handle() return type for Next.js 15 App router#4881mddanishh18 wants to merge 2 commits intohonojs:mainfrom
mddanishh18 wants to merge 2 commits intohonojs:mainfrom
Conversation
…s 15 App Router route handler types Automated by AI Dev Crew
fix: `hono/vercel` `handle()` return type is incompatible with Next.js 15 App Router route handler types
Member
|
Hi @mddanishh18 Thank you for the PR. Does this mean there is a possibility |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4881 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 177 177
Lines 11797 11797
Branches 3515 3514 -1
=======================================
Hits 10959 10959
Misses 837 837
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4877
What this PR does:
Updates the return type of the Vercel
handle()function to includevoid(andPromise<Response | void>). This is required because Next.js 15 App Router expects route handlers to optionally return void.