Skip to content

fix(node-ws): deprecated#1862

Open
yusukebe wants to merge 2 commits intomainfrom
fix/node-ws-deprecated
Open

fix(node-ws): deprecated#1862
yusukebe wants to merge 2 commits intomainfrom
fix/node-ws-deprecated

Conversation

@yusukebe
Copy link
Copy Markdown
Member

@yusukebe yusukebe commented Apr 21, 2026

The author should do the following, if applicable

  • Add tests
  • Run tests
  • yarn changeset at the top of this repo and push the changeset
  • Follow the contribution guide

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

🦋 Changeset detected

Latest commit: 3018464

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/node-ws Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe
Copy link
Copy Markdown
Member Author

Hey @nakasyou !

It's time to say goodbye to @hono/node-ws. Can you review this?

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.93%. Comparing base (bde8a44) to head (3018464).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1862   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files         114      114           
  Lines        3894     3894           
  Branches      994      994           
=======================================
  Hits         3580     3580           
  Misses        282      282           
  Partials       32       32           
Flag Coverage Δ
node-ws 80.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BarryThePenguin
Copy link
Copy Markdown
Contributor

Is it worth removing it from the CI too? Some other places I can think of include

  • eslint ignore
  • prettier ignore
  • remove from the root tsconfig.json

There may be more?

@yusukebe
Copy link
Copy Markdown
Member Author

Hi @BarryThePenguin

Is it worth removing it from the CI too? Some other places I can think of include

Ah, yes! We have to remove (ignore) them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants