global.crypto fix for Node 19.0#19
Merged
yusukebe merged 1 commit intohonojs:mainfrom Jan 24, 2023
doge1338:patch-1
Merged
Conversation
With Node.js 19.0, the Web Crypto API is now accessible directly from the global object. global.crypto is not writable so trying to assign to it crashes the program. This is a simple fix for it.
Member
|
Hi @doge1338 ! Thanks. This is a good fix! I'll merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Node.js 19.0, the Web Crypto API is now accessible directly from the global object. global.crypto is not writable so trying to assign to it crashes the program. This is a simple fix for it.