feat: add stream support and fix some bugs#28
Merged
yusukebe merged 2 commits intohonojs:mainfrom Mar 31, 2023
Merged
Conversation
Closed
yusukebe
reviewed
Mar 31, 2023
Member
|
Hi @tangye1234 ! Looks good! One thing. I've noticed there is a typo. |
Contributor
Author
Sure |
yusukebe
approved these changes
Mar 31, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, c.body(stream) is not very friendly to stream support.
Modify tsconfig es target to 2022 to support Error cause
hono throws a TimeoutError exception and returns a 504 instead of a 500 error.