feat: first class support for websockets#328
Conversation
f6892a1 to
6ea41a5
Compare
|
Hey @BlankParticle Sorry for being late. I think the direction of this PR is good! So, can you finalize this, or is this ready for review? I'd like to include this change to the next major version v2: #316 |
|
Simple question. If you add |
|
this design works then, users will need to pass in their own server, this PR is ready to go |
|
@BlankParticle Okay! Hey @nakasyou can you review this? (We don't need to add |
|
@BlankParticle Looks good! Thank you! |
fixes #307
There was some discussion around how we should do this, but it died down
I landed on a design that doesn't add any extra runtime dependency, the user needs to provide the websocket server themselves, which is a good compromise.
I am opening this PR so we can do discussion around this and easily reason about this,
this is not the final design and I will update this PR accordingly to the reviews/comments to better fit the goalcode was ported and adapted from
@hono/node-ws