refactor: improve handling of null body in response#341

Open

usualoma wants to merge 5 commits intov2from

Member

usualoma commented Apr 13, 2026 •

edited

Loading

This PR includes a minor bug fix and refactoring related to new Response(null), which was improved in #333.

Summary

fix: Fix an issue where Content-Type header was unnecessarily set on responses with a null body (e.g., new Response(null))
- https://github.com/honojs/node-server/pull/341/changes#diff-0a9945c399ef4b66209b330f33399ac079477f017039f62d33e7d8296163469dL160-R161
fix: Per the Fetch spec, responses with a null body should not include a Content-Type header
- https://github.com/honojs/node-server/pull/341/changes#diff-0a9945c399ef4b66209b330f33399ac079477f017039f62d33e7d8296163469dL265-R268
- https://github.com/honojs/node-server/pull/341/changes#diff-8c103f2199265c6a0659504dac715a5bc176ab1f494fc64fb06a5f4a814094c0L66-R68
refactor: Define defaultContentType as a constant and pass it explicitly to buildOutgoingHttpHeaders
- https://github.com/honojs/node-server/pull/341/changes#diff-8c103f2199265c6a0659504dac715a5bc176ab1f494fc64fb06a5f4a814094c0R6

usualoma added 5 commits

April 13, 2026 19:09


          refactor: accept default content type in buildOutgoingHttpHeaders

6cf7fe6


          refactor: define defaultContentType constant in response.ts

ccfe561


          test: add tests for default content-type

5fe988d


          refactor: improve handling of null body in response

5cdc481


          refactor: bun run format:fix

a2d2ab0

Member Author

usualoma commented Apr 13, 2026

Hi @yusukebe
Would you mind reviewing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet