docs(exception): complete app.onError example with non-HTTPException fallback#839
Merged
yusukebe merged 1 commit intohonojs:mainfrom Mar 19, 2026
Merged
Conversation
Member
|
@ramanverse Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes honojs/hono#2603
The
app.onErrorexample indocs/api/exception.mdended with a// ...placeholder, leaving readers with no guidance on how to handle errors that are not anHTTPException. The existing code also used internal twoslash---cut-start---/---cut-end---markers to hide the fallback from the rendered docs entirely.Changes
File:
docs/api/exception.md// ...placeholder and hidden twoslash cut blocks with a complete, visible fallbackconsole.error(err)and returnc.text('Internal Server Error', 500)error→errfor consistency with Hono's codebase styleBefore / After
Before:
After:
Impact
Docs-only change. No source code or tests modified.