fix(installer): wire MSI icon and add branded installer chrome#17
Merged
Conversation
hoobio
pushed a commit
that referenced
this pull request
Apr 27, 2026
This PR was generated automatically by [release-please](https://github.com/googleapis/release-please). --- ## [0.1.4](v0.1.3...v0.1.4) (2026-04-27) ### Bug Fixes * **installer:** wire MSI icon and add branded installer chrome ([#17](#17)) ([7881d1c](7881d1c)) ### Performance Improvements * **installer:** shrink MSI size ([#19](#19)) ([5666084](5666084)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please-hoobi[bot] <279189756+release-please-hoobi[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the missing icon on the installed Earmark entry in Add/Remove Programs and on the Start Menu shortcut, and brands the installer wizard with the Earmark logo (banner + Welcome/Exit dialog bitmap).
The icon issue is a WiX 5 compatibility quirk: WiX 5 dropped the
Icon/@Nameattribute, so the Id is used verbatim as the Icon table key. Without the.icoextension on the Id, the Shell shortcut renderer and ARP both fall back to the generic placeholder. This was also affecting the bitwarden-cmdpal installer; the same fix is going in there.Changes
installer/Earmark.wxs:EarmarkIcontoEarmarkIcon.icoso the Icon table key has the right extension; updated the matchingARPPRODUCTICONproperty and ShortcutIconreference.WixUIBannerBmpandWixUIDialogBmpWixVariables overriding the default WiX UI chrome.installer/WixUIBannerBmp.bmp(493x58): horizontal banner shown on License / InstallDir / Verify / Progress dialogs. Logo right-aligned to avoid colliding with the dialog title text on the left.installer/WixUIDialogBmp.bmp(493x312): full background for Welcome / Exit dialogs. Only the left ~164 px is visible; the strip uses a#1d1d1dpanel for contrast with the light-cyan logo.src/Earmark.App/Assets/logo.png..gitignore: excludepublish/,staging/,*.msi,*.wixpdb(local build outputs from validating the WiX changes).Testing
%LocalAppData%\Earmark\logs\shows the expectedApplied rule .../Skip Set .../Skip re-apply ...lines after the changetests/Earmark.Core.Testsdotnet test -p:Platform=x64) - no code changesdotnet publish+wix buildsucceeds (exit 0); producedEarmark-1.0.0-x64.msi. Inspected the MSI with the Windows Installer COM API: Icon table key isEarmarkIcon.ico,ARPPRODUCTICONandShortcut.Icon_both reference it correctly.Checklist