chore: temporarily disable cask distribution until code signing #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Comment out homebrew_casks section in .goreleaser/mac.yml - Remove deprecation warning from formula caveats (formula is now primary) - Update test script to focus on formula-only testing - Remove cask-related tests and validations - Update CI workflow to test only formula distribution - Enforce Gatekeeper compliance testing (removed bypass flag) All tests pass including installation validation and binary execution. Will re-enable cask distribution once Apple Developer certificate is in place.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily disables Homebrew cask distribution for the Hookdeck CLI due to code signing requirements, shifting focus to formula-only distribution until an Apple Developer certificate is in place.
Key changes:
- Comments out cask configuration in GoReleaser and removes deprecation warnings from formula
- Updates test scripts to focus only on formula validation and removes cask-related tests
- Enforces Gatekeeper compliance by removing bypass mechanisms for unsigned binaries
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test-scripts/test-homebrew-build.sh | Removes cask testing functions and Gatekeeper bypass options, enforces binary signing compliance |
| .goreleaser/mac.yml | Comments out homebrew_casks section and removes formula deprecation warning |
| .github/workflows/test-homebrew-build.yml | Updates CI workflow to exclude cask file from artifacts |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| echo " ✓ GoReleaser configuration generates correct Homebrew files" | ||
| echo " ✓ GoReleaser configuration generates correct Homebrew formula" | ||
| echo " ✓ Completion files are bundled in archives" | ||
| echo " ✓ Formula has deprecation warnings" |
There was a problem hiding this comment.
The validation message indicates that deprecation warnings are still being checked, but the actual deprecation warning validation was removed at line 183. This message should be removed or updated to reflect that deprecation warnings are no longer validated.
Suggested change
| echo " ✓ Formula has deprecation warnings" |
…s on all PRs to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests pass including installation validation and binary execution.
Will re-enable cask distribution once Apple Developer certificate is in place.