-
Notifications
You must be signed in to change notification settings - Fork 25
feat: add /tenants prefix to tenant-scoped API routes #617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add deprecation middleware that sets Deprecation and Link headers - Register tenant-scoped routes under both /tenants prefix (new) and root (deprecated) - Old paths still work but return deprecation headers pointing to new paths - Add integration tests for both path styles
Update all tenant-scoped API paths from /{tenant_id}/* to /tenants/{tenant_id}/*
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Update all e2e test paths from /{tenant_id}/* to /tenants/{tenant_id}/*
to use the new canonical API paths.
alexbouchardd
approved these changes
Jan 14, 2026
Contributor
I would remove this and force the upgrade |
Update test name strings to reflect the new /tenants/:tenantID path format for consistency with the actual API paths. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove the deprecation middleware and deprecated route registration. The old paths without /tenants prefix are no longer supported. Changes: - Remove deprecation_middleware.go and its tests - Remove deprecated route group registration from router.go - Update all unit tests to use /tenants/:tenantID path format Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…route-prefix # Conflicts: # docs/apis/openapi.yaml
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
/tenantsprefix to all tenant-scoped routesChanges
/api/v1/tenants/:tenantID/*/api/v1/:tenantID/*) still work but returnDeprecationandLinkheaders