fix: Relax destination URL/hostname validation regex#739
Merged
Conversation
Simplify the URL pattern to ^https?://[^\s]+$ for webhook, webhook_standard, aws_sqs, and aws_kinesis destinations. The previous regex was overly strict and blocked valid URLs with Basic Auth credentials (e.g., https://user:pass@example.com). Go's net/http already validates URLs at request time, so a permissive check is sufficient. Closes #733 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The root-level DESTINATION_METADATA_PATH was never wired up in the service builder — it was parsed but never used. Remove it to avoid confusion. Use DESTINATIONS_METADATA_PATH instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ridden Document that DESTINATIONS_METADATA_PATH only allows overriding non-core fields (label, description, icon, instructions). Also fix the link to the default metadata providers folder. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Simplify the server_url pattern to ^[^\s]+$ so hostnames without dots (e.g., rabbitmq:5672) are accepted. The previous regex required a dotted FQDN, blocking Docker service discovery names. Ref #549 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexbouchardd
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
^https?://[^\s]+$for webhook, webhook_standard, aws_sqs, and aws_kinesis destinations. The previous regex blocked valid URLs with Basic Auth credentials.server_urlvalidation to^[^\s]+$so Docker service names likerabbitmq:5672work without requiring a dotted FQDN.DESTINATION_METADATA_PATH(singular) root-level config option that was never wired up.config_fieldsandcredential_fieldscannot be overridden viaDESTINATIONS_METADATA_PATH.Closes #733, #549
Test plan
🤖 Generated with Claude Code