fix: warn instead of crash when operator events topics configured without sink#835
Merged
fix: warn instead of crash when operator events topics configured without sink#835
Conversation
…hout sink When topics are configured but no sink is set, the server would crash on startup with a fatal error. Instead, log a warning and return a NoopSink so the server can start gracefully (operator events will be dropped). Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
alexbouchardd
approved these changes
Apr 14, 2026
Replace stdlib log/slog with the project's *logging.Logger for consistency. NewSink now accepts a logger parameter, and callers in builder.go pass b.logger. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opevents.Topicsare configured but no sink is set, the server previously crashed on startup with a fatal errorslog.Warnand returns aNoopSink, allowing the server to start gracefully (operator events will be dropped)internal/opevents/config.gois changedTest plan
🤖 Generated with Claude Code