fix(portal): resolve destination-types loading race that blanks the page#914
Merged
Merged
Conversation
useDestinationTypes returned `{}` while the SWR fetch was pending,
which is truthy. Callers' `destination_types && destinations` gates
therefore passed before destination-types had loaded, and the list
view crashed in render on `destination_types[destination.type].icon`
when /destinations resolved before /destination-types. ErrorBoundary
caught the crash and blanked the route, requiring several reloads
(SWR cache warm-up) for the page to render.
Return `undefined` while loading so the existing truthy gates
actually mean "everything loaded". Update the two call sites that
indexed the map (`useDestinationType`, `CreateDestination`'s context)
to handle the new nullable return.
alexbouchardd
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useDestinationTypesreturned{}while the SWR fetch was pending. Empty object is truthy, so callers'destination_types && destinationsgates passed before the types had loaded — and when/destinationsresolved before/destination-types, the list view crashed in render ondestination_types[destination.type].icon. ErrorBoundary blanked the route, requiring several reloads (SWR cache warm-up) for the page to render. Returnundefinedwhile loading so the existing gates actually mean "everything loaded".