Conversation
`git hop prune --dry-run` was performing the prune instead of
previewing it: runPrune never read the persistent --dry-run flag.
Refactor:
- runPrune now reads the flag via cmd.Flags().GetBool("dry-run")
- Extract runPruneFS(fs, st, dryRun) helper for unit testing
- pruneOrphanedWorktrees / pruneOrphanedHubs take dryRun and only
mutate state when false; both prefix log lines with "[dry-run]
Would prune" or "Pruning" depending on mode
- state.SaveState is gated on !dryRun
Also updates the only other caller (cmd/doctor.go --fix path) to
pass dryRun=false explicitly.
Tests:
- TestRunPrune_DryRun: state.json on disk is unchanged after a
dry-run that reports 1 orphan
- TestRunPrune_Apply: in-memory state is mutated when dryRun=false
- Existing pruneOrphanedWorktrees/Hubs tests updated for new sig
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git hop prune --dry-runwas performing the prune instead of previewing it —runPrunenever read the persistent--dry-runflag.runPruneFS(fs, st, dryRun)so the wiring is unit-testable; the prune helpers takedryRunand only mutate state when false;state.SaveStateis gated on!dryRun.[dry-run] Would prunevsPruningdepending on mode, so the CLI output makes the difference visible.--fixpath passesdryRun=falseexplicitly (no behavior change).Closes T-0175.
Test plan
go build ./...go test ./cmd/... ./internal/...— 698/698 pass (was 695; +3 new)TestRunPrune_DryRun— state.json unchanged after dry-run reporting 1 orphanTestRunPrune_Apply— in-memory state mutated when dryRun=falseprune --dry-runpreserves it and prefixes logs with[dry-run] Would prune; subsequentprune(no flag) removes it