Add old shuttle pro (aka V1)#1
Merged
Merged
Conversation
Owner
|
Does the Shuttle Pro v1 have 16 buttons too? I thought it was only 15. |
Contributor
Author
|
As I understand, v2 add two button on the side of the shuttle, v1 have 13
buttons (9 on top and 4 on bottom) and v2 have 15 (one on each side).
I think mask value are same (for common buttons) but I don't have anymore
the v2 version to check it ...
I already wrote my own driver for embedded system long time ago for v1 and
v2.
…On Sun, Nov 13, 2022, 6:45 a.m. hopejr ***@***.***> wrote:
Does the Shuttle Pro v1 have 16 buttons too? I thought it was only 15.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADUTQIEFSCPFZCHKSRQ6LTWIDIFNANCNFSM6AAAAAAR433BQ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Sorry, I forgot it was only 15 on v2. It's been a while since I've looked at this. Do you know what the button masks for v1 are? It would be good to remove any of the v2 ones that aren't on v1 from it's list. |
Contributor
Author
|
I try to make it visually. values are bit position or "mask = 1 <<
(value-1)". EI 1 = 1, 13 = 4096.
1 2 3 4
5 6 7 8 9
x (shuttle) x (x = no button .... version 2 have)
10 11
12 13
…On Sun, Nov 13, 2022 at 2:45 PM hopejr ***@***.***> wrote:
Sorry, I forgot it was only 15 on v2. It's been a while since I've looked
at this. Do you know what the button masks for v1 are? It would be good to
remove any of the v2 ones that aren't on v1 from it's list.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADUTQOSABWBBEJNJZ6FB6DWIFAONANCNFSM6AAAAAAR433BQ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
Ok, then we'll need to change the masks array to: (Minus the 0x2000 and 0x4000 at the end). |
Updated button masks, readme, tests, etc for ShuttlePro V1. Also updated dependencies.
Owner
|
I've just updated the button masks, as well as the readme, etc. Will merge this now. Thank you for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old shuttle pro (aka V1)