Skip to content

Output the BC index when running into the error of finding multiple BCs on the same internal face#108

Merged
kopperp merged 2 commits intomainfrom
output.error.internal.face.multiple.BCs
Mar 13, 2026
Merged

Output the BC index when running into the error of finding multiple BCs on the same internal face#108
kopperp merged 2 commits intomainfrom
output.error.internal.face.multiple.BCs

Conversation

@scopplestone
Copy link
Copy Markdown
Collaborator

Added bcs[bcID].type to the error message to indicate which BC is leading to the error so the user can identify the location of his/her error in the .ini file.

@scopplestone scopplestone requested a review from kopperp March 10, 2026 15:35
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 10, 2026

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2987 2684 90% 85% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
pyhope/mesh/connect/connect.py 98% 🟢
TOTAL 98% 🟢

updated for commit: 7d7c23d by action🐍

Copy link
Copy Markdown
Collaborator

@kopperp kopperp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. However, I would suggest outputting the actual bcID as this is probably more helpful to the user than the type as the latter might be identical for several or all BCs.

…han the type as the latter might be identical for several or all BCs.
@kopperp kopperp force-pushed the output.error.internal.face.multiple.BCs branch from fde1ab3 to 7d7c23d Compare March 13, 2026 20:55
@kopperp kopperp self-requested a review March 13, 2026 20:55
@kopperp kopperp merged commit 67027bf into main Mar 13, 2026
14 checks passed
@kopperp kopperp deleted the output.error.internal.face.multiple.BCs branch March 13, 2026 21:00
kopperp added a commit that referenced this pull request Mar 18, 2026
…e.multiple.BCs

Output the BC index when running into the error of finding multiple BCs on the same internal face
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants