Skip to content

feat: file-based env vars for e2e tests #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickleet merged 4 commits into from
Mar 17, 2026
Merged

feat: file-based env vars for e2e tests #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f36c6bb
feat: use file-based env vars for e2e tests
patrickleet Mar 11, 2026
20714f9
chore: use e2e workflow v2.19.1 (released)
patrickleet Mar 11, 2026
4888a89
chore: add write-env-files: true for explicit env file opt-in
patrickleet Mar 11, 2026
253e153
chore: update workflows-crossplane to v2.20.0 (write-env-files support)
patrickleet Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions .github/workflows/on-pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ permissions:

jobs:
validate:
uses: unbounded-tech/workflows-crossplane/.github/workflows/validate.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/validate.yaml@v2.20.0
with:
examples: |
[
Expand All @@ -46,10 +46,10 @@ jobs:
error_on_missing_schemas: true

test:
uses: unbounded-tech/workflows-crossplane/.github/workflows/test.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/test.yaml@v2.20.0

e2e:
uses: unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@v2.20.0
secrets:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand All @@ -60,12 +60,39 @@ jobs:
aws-region: us-east-2
timeout-minutes: 30
cleanup-timeout-minutes: 30
write-env-files: true
env-vars: |
{
"IPAM_POOL_REGIONAL_IPV4": "${{ vars.IPAM_POOL_REGIONAL_IPV4 }}",
"IPAM_POOL_REGIONAL_IPV6": "${{ vars.IPAM_POOL_REGIONAL_IPV6 }}",
"NETWORK_VPC": "${{ vars.NETWORK_VPC }}",
"NETWORK_IGW": "${{ vars.NETWORK_IGW }}",
"NETWORK_EIGW": "${{ vars.NETWORK_EIGW }}",
"NETWORK_SUBNET_PRIVATE_A": "${{ vars.NETWORK_SUBNET_PRIVATE_A }}",
"NETWORK_SUBNET_PRIVATE_B": "${{ vars.NETWORK_SUBNET_PRIVATE_B }}",
"NETWORK_SUBNET_PRIVATE_C": "${{ vars.NETWORK_SUBNET_PRIVATE_C }}",
"NETWORK_SUBNET_PUBLIC_A": "${{ vars.NETWORK_SUBNET_PUBLIC_A }}",
"NETWORK_SUBNET_PUBLIC_B": "${{ vars.NETWORK_SUBNET_PUBLIC_B }}",
"NETWORK_SUBNET_PUBLIC_C": "${{ vars.NETWORK_SUBNET_PUBLIC_C }}",
"NETWORK_RT_PUBLIC": "${{ vars.NETWORK_RT_PUBLIC }}",
"NETWORK_RT_PRIVATE_A": "${{ vars.NETWORK_RT_PRIVATE_A }}",
"NETWORK_RT_PRIVATE_B": "${{ vars.NETWORK_RT_PRIVATE_B }}",
"NETWORK_RT_PRIVATE_C": "${{ vars.NETWORK_RT_PRIVATE_C }}",
"NETWORK_RTA_PUBLIC_A": "${{ vars.NETWORK_RTA_PUBLIC_A }}",
"NETWORK_RTA_PUBLIC_B": "${{ vars.NETWORK_RTA_PUBLIC_B }}",
"NETWORK_RTA_PUBLIC_C": "${{ vars.NETWORK_RTA_PUBLIC_C }}",
"NETWORK_RTA_PRIVATE_A": "${{ vars.NETWORK_RTA_PRIVATE_A }}",
"NETWORK_RTA_PRIVATE_B": "${{ vars.NETWORK_RTA_PRIVATE_B }}",
"NETWORK_RTA_PRIVATE_C": "${{ vars.NETWORK_RTA_PRIVATE_C }}",
"NAT_GATEWAY_A": "${{ vars.NAT_GATEWAY_A }}",
"EIP_ALLOCATION_A": "${{ vars.EIP_ALLOCATION_A }}"
}

publish:
needs:
- validate
- test
uses: unbounded-tech/workflows-crossplane/.github/workflows/publish.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/publish.yaml@v2.20.0
secrets: inherit
with:
tag: pr-${{ github.event.pull_request.number }}-${{ github.sha }}
33 changes: 30 additions & 3 deletions .github/workflows/on-push-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ permissions:
jobs:

validate:
uses: unbounded-tech/workflows-crossplane/.github/workflows/validate.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/validate.yaml@v2.20.0
with:
examples: |
[
Expand All @@ -43,10 +43,10 @@ jobs:
error_on_missing_schemas: true

test:
uses: unbounded-tech/workflows-crossplane/.github/workflows/test.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/test.yaml@v2.20.0

e2e:
uses: unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@v2.14.2
uses: unbounded-tech/workflows-crossplane/.github/workflows/e2e.yaml@v2.20.0
secrets:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand All @@ -57,6 +57,33 @@ jobs:
aws-region: us-east-2
timeout-minutes: 30
cleanup-timeout-minutes: 30
write-env-files: true
env-vars: |
{
"IPAM_POOL_REGIONAL_IPV4": "${{ vars.IPAM_POOL_REGIONAL_IPV4 }}",
"IPAM_POOL_REGIONAL_IPV6": "${{ vars.IPAM_POOL_REGIONAL_IPV6 }}",
"NETWORK_VPC": "${{ vars.NETWORK_VPC }}",
"NETWORK_IGW": "${{ vars.NETWORK_IGW }}",
"NETWORK_EIGW": "${{ vars.NETWORK_EIGW }}",
"NETWORK_SUBNET_PRIVATE_A": "${{ vars.NETWORK_SUBNET_PRIVATE_A }}",
"NETWORK_SUBNET_PRIVATE_B": "${{ vars.NETWORK_SUBNET_PRIVATE_B }}",
"NETWORK_SUBNET_PRIVATE_C": "${{ vars.NETWORK_SUBNET_PRIVATE_C }}",
"NETWORK_SUBNET_PUBLIC_A": "${{ vars.NETWORK_SUBNET_PUBLIC_A }}",
"NETWORK_SUBNET_PUBLIC_B": "${{ vars.NETWORK_SUBNET_PUBLIC_B }}",
"NETWORK_SUBNET_PUBLIC_C": "${{ vars.NETWORK_SUBNET_PUBLIC_C }}",
"NETWORK_RT_PUBLIC": "${{ vars.NETWORK_RT_PUBLIC }}",
"NETWORK_RT_PRIVATE_A": "${{ vars.NETWORK_RT_PRIVATE_A }}",
"NETWORK_RT_PRIVATE_B": "${{ vars.NETWORK_RT_PRIVATE_B }}",
"NETWORK_RT_PRIVATE_C": "${{ vars.NETWORK_RT_PRIVATE_C }}",
"NETWORK_RTA_PUBLIC_A": "${{ vars.NETWORK_RTA_PUBLIC_A }}",
"NETWORK_RTA_PUBLIC_B": "${{ vars.NETWORK_RTA_PUBLIC_B }}",
"NETWORK_RTA_PUBLIC_C": "${{ vars.NETWORK_RTA_PUBLIC_C }}",
"NETWORK_RTA_PRIVATE_A": "${{ vars.NETWORK_RTA_PRIVATE_A }}",
"NETWORK_RTA_PRIVATE_B": "${{ vars.NETWORK_RTA_PRIVATE_B }}",
"NETWORK_RTA_PRIVATE_C": "${{ vars.NETWORK_RTA_PRIVATE_C }}",
"NAT_GATEWAY_A": "${{ vars.NAT_GATEWAY_A }}",
"EIP_ALLOCATION_A": "${{ vars.EIP_ALLOCATION_A }}"
}

version-and-tag:
name: Version and Tag
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ _output/
.venv/
.tmp/
tests/**/secrets
tests/**/env/
53 changes: 25 additions & 28 deletions tests/e2etest-network/main.k
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,58 +42,55 @@ _base64_creds = base64.encode(_creds)
# =============================================================================
# IPAM Pools - from aws-ipam e2e test
# Get pool IDs: aws ec2 describe-ipam-pools --query 'IpamPools[*].[IpamPoolId,AddressFamily,Description]' --output table
_ipv4_private_pool_id = "ipam-pool-0607416fa3707147a"
_ipv6_private_pool_id = "ipam-pool-0ca730678e463dbfc"
_ipv4_private_pool_id = file.read("env/IPAM_POOL_REGIONAL_IPV4").strip()
_ipv6_private_pool_id = file.read("env/IPAM_POOL_REGIONAL_IPV6").strip()

# Orphan policy - no Delete means resources persist in AWS after claim deletion
_orphan = ["Create", "Observe", "Update", "LateInitialize"]

# External names for import (leave empty for create, populate for import)
# VPC: vpc-0c20c458dcb738f21
_vpc_external_name = "vpc-0c20c458dcb738f21"
_vpc_external_name = file.read("env/NETWORK_VPC").strip()

# Internet Gateway: igw-0a11d99e3cc584333
_igw_external_name = "igw-0a11d99e3cc584333"
_igw_external_name = file.read("env/NETWORK_IGW").strip()

# Egress-Only Internet Gateway: eigw-02d33bcb5e87d8353
_eigw_external_name = "eigw-02d33bcb5e87d8353"
_eigw_external_name = file.read("env/NETWORK_EIGW").strip()

# Subnets
_subnet_external_names = {
"public-c": "subnet-0739c3679702306eb"
"private-a": "subnet-0ba2f584c25e9435d"
"public-a": "subnet-0f17f94da9c13d3fe"
"public-b": "subnet-0f09414e8042cbee9"
"private-b": "subnet-02e4d512f8859e684"
"private-c": "subnet-0a46f41be19e3ef54"
"public-c": file.read("env/NETWORK_SUBNET_PUBLIC_C").strip()
"private-a": file.read("env/NETWORK_SUBNET_PRIVATE_A").strip()
"public-a": file.read("env/NETWORK_SUBNET_PUBLIC_A").strip()
"public-b": file.read("env/NETWORK_SUBNET_PUBLIC_B").strip()
"private-b": file.read("env/NETWORK_SUBNET_PRIVATE_B").strip()
"private-c": file.read("env/NETWORK_SUBNET_PRIVATE_C").strip()
}

# Route Tables
_route_table_external_names = {
"public": "rtb-0ec6e6b72b4069f6d"
"private-a": "rtb-0123083a1a6980352"
"private-b": "rtb-0f3651ed2fa86b78c"
"private-c": "rtb-00bcd173ff8e26c91"
"public": file.read("env/NETWORK_RT_PUBLIC").strip()
"private-a": file.read("env/NETWORK_RT_PRIVATE_A").strip()
"private-b": file.read("env/NETWORK_RT_PRIVATE_B").strip()
"private-c": file.read("env/NETWORK_RT_PRIVATE_C").strip()
}

# Route Table Associations
_rta_external_names = {
"public-a": "rtbassoc-0f55cb72f58eba3c6"
"public-b": "rtbassoc-0e260598fc03c1bda"
"public-c": "rtbassoc-0ed529b17080a7ff5"
"private-a": "rtbassoc-05a8500db23f7e5c4"
"private-b": "rtbassoc-04181252701b445f0"
"private-c": "rtbassoc-0f81cf5c3e798aa8c"
"public-a": file.read("env/NETWORK_RTA_PUBLIC_A").strip()
"public-b": file.read("env/NETWORK_RTA_PUBLIC_B").strip()
"public-c": file.read("env/NETWORK_RTA_PUBLIC_C").strip()
"private-a": file.read("env/NETWORK_RTA_PRIVATE_A").strip()
"private-b": file.read("env/NETWORK_RTA_PRIVATE_B").strip()
"private-c": file.read("env/NETWORK_RTA_PRIVATE_C").strip()
}

# NAT Gateways (populate after first run with NAT enabled)
# Get NAT IDs: kubectl get natgateway -l crossplane.io/composite=hops-test -o jsonpath='{range .items[*]}{.metadata.name}{"\t"}{.status.atProvider.id}{"\n"}{end}'
# Get EIP IDs: kubectl get eip -l crossplane.io/composite=hops-test -o jsonpath='{range .items[*]}{.metadata.name}{"\t"}{.status.atProvider.allocationId}{"\n"}{end}'
_nat_external_names = {
"a": "nat-05a5e2c13be4c716a"
"a": file.read("env/NAT_GATEWAY_A").strip()
}
_eip_external_names = {
"a": "eipalloc-09da84030949b878c"
"a": file.read("env/EIP_ALLOCATION_A").strip()
}

# =============================================================================
Expand Down Expand Up @@ -121,7 +118,7 @@ _items = [
providerConfigRef: {
name: "default"
}
region: "us-east-2"
region: file.read("env/AWS_REGION").strip()
tags: {
"hops.ops.com.ai/test-repo": "https://github.com/hops-ops/aws-network"
"hops.ops.com.ai/test-run-time": _now
Expand Down Expand Up @@ -168,7 +165,7 @@ _items = [
providerConfigRef: {
name: "default"
}
region: "us-east-2"
region: file.read("env/AWS_REGION").strip()
tags: {
"hops.ops.com.ai/test-repo": "https://github.com/hops-ops/aws-network"
"hops.ops.com.ai/test-run-time": _now
Expand Down
Loading