Skip to content

fix: tune cert-manager resource defaults#7

Merged
patrickleet merged 1 commit into
mainfrom
feat/cert-manager-resource-defaults
May 25, 2026
Merged

fix: tune cert-manager resource defaults#7
patrickleet merged 1 commit into
mainfrom
feat/cert-manager-resource-defaults

Conversation

@patrickleet
Copy link
Copy Markdown
Contributor

Summary

  • set default requests/limits for cert-manager controller
  • set default requests/limits for cainjector and webhook
  • keep spec.values merge behavior and overrideAllValues replacement behavior intact
  • update render tests for the new defaults

Verification

  • make test: 6/6 passed
  • Colima: CertStack/default pat-local is Synced=True Ready=True
  • Colima: Helm Release cert-manager is Synced=True Ready=True with the rendered resources
  • Target aws/hops/pat-local: deployment cert-manager/cert-manager has requests cpu=15m memory=100Mi and limits cpu=200m memory=256Mi, 1/1 ready
  • Target aws/hops/pat-local: deployment cert-manager/cert-manager-cainjector has requests cpu=15m memory=194Mi and limits cpu=100m memory=512Mi, 1/1 ready
  • Target aws/hops/pat-local: deployment cert-manager/cert-manager-webhook has requests cpu=15m memory=100Mi and limits cpu=100m memory=256Mi, 1/1 ready

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Warning

Review limit reached

@patrickleet, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 48 minutes and 33 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 532d2e88-eba4-40d1-acbf-76f5d6c8c8bb

📥 Commits

Reviewing files that changed from the base of the PR and between 3f4774d and a6999be.

📒 Files selected for processing (2)
  • functions/render/200-cert-manager.yaml.gotmpl
  • tests/test-render/main.k
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/cert-manager-resource-defaults

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/cert-stack:pr-7-8788ebc2d8f2d43566f4a9c6af014188d8d521aa

View Package

@patrickleet patrickleet merged commit ea62203 into main May 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant