Skip to content

feat: add argocd resource defaults and nodepool#29

Merged
patrickleet merged 1 commit into
mainfrom
feat/argocd-resource-defaults-nodepool
May 25, 2026
Merged

feat: add argocd resource defaults and nodepool#29
patrickleet merged 1 commit into
mainfrom
feat/argocd-resource-defaults-nodepool

Conversation

@patrickleet
Copy link
Copy Markdown
Contributor

Summary

  • add explicit Argo CD resource defaults across controller, server, repo-server, redis, dex, notifications, and applicationset
  • add optional dedicated hops-gitops NodePool support with workload-type=gitops placement values
  • add a nodepool example and render test coverage

Verification

  • make test: 18/18 passed
  • Colima: GitopsStack/default pat-local is Synced=True Ready=True
  • Colima: Helm Release argocd is Synced=True Ready=True
  • Target aws/hops/pat-local: all Argo CD workloads are ready with explicit resources:
    • application-controller: requests cpu=548m memory=2062Mi, limit memory=2062Mi, 1/1 ready
    • repo-server: requests cpu=15m memory=100Mi, limits cpu=500m memory=512Mi, 1/1 ready
    • server: requests cpu=15m memory=100Mi, limits cpu=250m memory=256Mi, 1/1 ready
    • applicationset/dex/notifications/redis: requests cpu=15m memory=100Mi, limits cpu=100m memory=256Mi, each 1/1 ready

NodePool note

The NodePool path is render-tested but not active on pat-local. The current local GitopsStack claim does not set nodePool.enabled=true, so no hops-gitops NodePool exists and I did not roll Argo CD onto a new tainted pool without an explicit live-cluster change.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 25, 2026

Warning

Review limit reached

@patrickleet, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 1 review of capacity. Refill in 41 minutes and 45 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c7c4a838-78bf-48fb-854d-9769255d30a3

📥 Commits

Reviewing files that changed from the base of the PR and between 35424fe and 05b1953.

📒 Files selected for processing (7)
  • Makefile
  • apis/gitopsstacks/definition.yaml
  • examples/gitopsstacks/nodepool.yaml
  • functions/render/000-state-init.yaml.gotmpl
  • functions/render/155-nodepool.yaml.gotmpl
  • functions/render/200-helm-release-argocd.yaml.gotmpl
  • tests/test-render/main.k
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/argocd-resource-defaults-nodepool

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Published Crossplane Package

The following Crossplane package was published as part of this PR:

Package: ghcr.io/hops-ops/gitops-stack:pr-29-dc5bdffc71e771faab69bf687bbd1dfe9f61d6dd

View Package

@patrickleet patrickleet merged commit 718369b into main May 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant