Skip to content

fix: add missing explicit property declarations to avoid deprecated dynamic property errors#14

Open
amulet1 wants to merge 3 commits intohorde:FRAMEWORK_6_0from
amulet1:fix_dynamic_properties
Open

fix: add missing explicit property declarations to avoid deprecated dynamic property errors#14
amulet1 wants to merge 3 commits intohorde:FRAMEWORK_6_0from
amulet1:fix_dynamic_properties

Conversation

@amulet1
Copy link
Collaborator

@amulet1 amulet1 commented Mar 13, 2026

Add missing explicit property declarations to avoid deprecated dynamic property errors:

  • Declare $_request, $_driver, $_state, $_policykey
  • Fix typo: Horde_Controller_Reqeust_Http -> Horde_Controller_Request_Http

This is a simple fix, but maybe we should also refactor a little bit?

It looks like this class is not extended, and only used in one place. Maybe it makes sense to:

  • use constructor property promotion,
  • drop _ from variable names and add explicit types where is it absolutely clear.

Or we can do it later.

…ynamic property errors

- Declare $_request, $_driver, $_state, $_policykey
- Fix typo: Horde_Controller_Reqeust_Http -> Horde_Controller_Request_Http
@amulet1 amulet1 requested a review from ralflang March 13, 2026 00:55
@amulet1 amulet1 self-assigned this Mar 13, 2026
@amulet1
Copy link
Collaborator Author

amulet1 commented Mar 13, 2026

Also:

  • add missing classes accidentally omitted in prior fixes
  • add return type declaration to getIterator()

A new alpha release is requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant