Fix/misc#124
Merged
Merged
Conversation
Add a check for flags before processing changes to avoid errors.
ralflang
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PHP warnings from missing optional Horde data and restore default log timestamps:
prefGroupsand_prefsentries as empty arrays when loading app preferences.Why
Some apps or config states may not define preference groups, and some ActiveSync IMAP change sets can include UIDs without complete flag/category metadata. These cases should not produce PHP
Undefined array keywarnings during normal operation.The default PSR logger path was using a message-only formatter, which dropped the timestamp and log level from file logs. Using the default
SimpleFormattermatches the legacy Horde log format.Test Plan
php -lon:vendor/horde/core/lib/Horde/Core/Prefs/Ui.phpvendor/horde/core/lib/Horde/Core/ActiveSync/Driver.phpvendor/horde/core/src/Factory/LogHandlerFactory.php