Skip to content

Fix/notes deletion#126

Merged
TDannhauer merged 2 commits into
FRAMEWORK_6_0from
fix/notes_deletion
May 25, 2026
Merged

Fix/notes deletion#126
TDannhauer merged 2 commits into
FRAMEWORK_6_0from
fix/notes_deletion

Conversation

@TDannhauer
Copy link
Copy Markdown
Contributor

Summary

This updates the ActiveSync Notes delete path to work correctly with non-multiplexed Notes collections.

  • Pass the active Notes folder/notepad id through notes_delete() so Mnemo can delete within the correct separate collection.
  • Process Notes deletes per UID so one stale or already-missing item from the client does not prevent later deletes in the same SYNC request.
  • Fix Notes delete recovery to query notes_getActionTimestamp() instead of the unrelated Tasks timestamp lookup.

Test Plan

  • Verified PHP syntax for vendor/horde/core/lib/Horde/Core/ActiveSync/Driver.php.
  • Verified PHP syntax for vendor/horde/core/lib/Horde/Core/ActiveSync/Connector.php.
  • Ran ActiveSync device tests:
    vendor/bin/phpunit --bootstrap vendor/autoload.php vendor/horde/activesync/test/Horde/ActiveSync/DeviceTest.php
  • Ran core ActiveSync tests with required package mocks loaded:
    OK (8 tests, 32 assertions)

Updated notes_delete method to accept an optional notepad parameter for improved functionality.
@TDannhauer TDannhauer requested a review from ralflang May 25, 2026 14:44
@TDannhauer TDannhauer merged commit 3fb9c3a into FRAMEWORK_6_0 May 25, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants