fix(security): restrict unserialize allowed_classes (ZDI-20-1051)#129
Merged
Conversation
Add allowed_classes parameter to all unserialize() calls to prevent PHP object injection via crafted serialized data in preferences, cache entries, and database fields. - 14 calls use allowed_classes => false (data-only: arrays, scalars) - 1 call uses explicit whitelist [Horde_Themes_Cache::class] - Covers prefs, block layouts, login tasks, signup data, theme cache, tagger cache, ActiveSync config, IMSP share params, and Facebook prefs
This was referenced May 27, 2026
Member
Author
ZDI-20-1051 related PRs across the Horde ecosystem
|
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allowed_classesparameter to all 17unserialize()calls in Core to prevent PHP object injection attacksallowed_classes => false(data stored is arrays/scalars only)Factory/ThemesCache.php) uses explicit whitelist[Horde_Themes_Cache::class]since it legitimately stores a serialized object