fix(http): resolve dynamic property deprecation in Mock client

.gitignore

@@ -49,3 +49,9 @@ composer.lock
 /phpstan.neon
 # PHPStan cache directory
 /.phpstan.cache/
+
+# Added by horde-components QC --fix-qc-issues
+# Horde installer plugin runtime data
+/var/
+# Horde installer plugin web-accessible directory
+/web/

.horde.yml

@@ -52,3 +52,4 @@ vendor: horde
 quality:
   phpstan:
     level: 9
+keywords: []

lib/Horde/Http.php

@@ -1,6 +1,7 @@
 <?php
+
 /**
- * Copyright 2007-2017 Horde LLC (http://www.horde.org/)
+ * Copyright 2007-2026 Horde LLC (http://www.horde.org/)
  *
  * See the enclosed file LICENSE for license information (BSD). If you
  * did not receive this file, see http://www.horde.org/licenses/bsd.
@@ -25,16 +26,16 @@ class Horde_Http
     /**
      * Authentication schemes
      */
-    const AUTH_ANY = 'ANY';
-    const AUTH_BASIC = 'BASIC';
-    const AUTH_DIGEST = 'DIGEST';
-    const AUTH_NTLM = 'NTLM';
-    const AUTH_GSSNEGOTIATE = 'GSSNEGOTIATE';
+    public const AUTH_ANY = 'ANY';
+    public const AUTH_BASIC = 'BASIC';
+    public const AUTH_DIGEST = 'DIGEST';
+    public const AUTH_NTLM = 'NTLM';
+    public const AUTH_GSSNEGOTIATE = 'GSSNEGOTIATE';
 
     /**
      * Proxy types
      */
-    const PROXY_HTTP = 0;
-    const PROXY_SOCKS4 = 1;
-    const PROXY_SOCKS5 = 2;
+    public const PROXY_HTTP = 0;
+    public const PROXY_SOCKS4 = 1;
+    public const PROXY_SOCKS5 = 2;
 }

lib/Horde/Http/Client.php

@@ -1,6 +1,7 @@
 <?php
+
 /**
- * Copyright 2007-2017 Horde LLC (http://www.horde.org/)
+ * Copyright 2007-2026 Horde LLC (http://www.horde.org/)
  *
  * See the enclosed file LICENSE for license information (BSD). If you
  * did not receive this file, see http://www.horde.org/licenses/bsd.
@@ -99,7 +100,7 @@ class Horde_Http_Client
      *                    constructor. See the class properties for available
      *                    settings.
      */
-    public function __construct($args = array())
+    public function __construct($args = [])
     {
         // Set or create request object
         if (isset($args['request'])) {
@@ -124,7 +125,7 @@ public function __construct($args = array())
      * @throws Horde_Http_Exception
      * @return Horde_Http_Response_Base
      */
-    public function get($uri = null, $headers = array())
+    public function get($uri = null, $headers = [])
     {
         return $this->request('GET', $uri, null, $headers);
     }
@@ -139,7 +140,7 @@ public function get($uri = null, $headers = array())
      * @throws Horde_Http_Exception
      * @return Horde_Http_Response_Base
      */
-    public function post($uri = null, $data = null, $headers = array())
+    public function post($uri = null, $data = null, $headers = [])
     {
         return $this->request('POST', $uri, $data, $headers);
     }
@@ -154,11 +155,11 @@ public function post($uri = null, $data = null, $headers = array())
      * @throws Horde_Http_Exception
      * @return Horde_Http_Response_Base
      */
-    public function put($uri = null, $data = null, $headers = array())
+    public function put($uri = null, $data = null, $headers = [])
     {
         if ($this->_httpMethodOverride) {
             $headers = array_merge(
-                array('X-HTTP-Method-Override' => 'PUT'),
+                ['X-HTTP-Method-Override' => 'PUT'],
                 $headers
             );
             return $this->post($uri, $data, $headers);
@@ -176,11 +177,11 @@ public function put($uri = null, $data = null, $headers = array())
      * @throws Horde_Http_Exception
      * @return Horde_Http_Response_Base
      */
-    public function delete($uri = null, $headers = array())
+    public function delete($uri = null, $headers = [])
     {
         if ($this->_httpMethodOverride) {
             $headers = array_merge(
-                array('X-HTTP-Method-Override' => 'DELETE'),
+                ['X-HTTP-Method-Override' => 'DELETE'],
                 $headers
             );
             return $this->post($uri, null, $headers);
@@ -198,7 +199,7 @@ public function delete($uri = null, $headers = array())
      * @throws Horde_Http_Exception
      * @return Horde_Http_Response_Base
      */
-    public function head($uri = null, $headers = array())
+    public function head($uri = null, $headers = [])
     {
         return $this->request('HEAD', $uri, null, $headers);
     }
@@ -220,9 +221,11 @@ public function head($uri = null, $headers = array())
      * @return Horde_Http_Response_Base
      */
     public function request(
-        $method, $uri = null, $data = null, $headers = array()
-    )
-    {
+        $method,
+        $uri = null,
+        $data = null,
+        $headers = []
+    ) {
         if ($method !== null) {
             $this->request->method = $method;
         }
@@ -251,7 +254,7 @@ public function request(
      */
     public function __get($name)
     {
-        return isset($this->{'_' . $name}) ? $this->{'_' . $name} : null;
+        return $this->{'_' . $name} ?? null;
     }
 
     /**
@@ -271,7 +274,7 @@ public function __set($name, $value)
             }
         }
 
-        list($object, $objectkey) = explode('.', $name, 2);
+        [$object, $objectkey] = explode('.', $name, 2);
         if ($object == 'request') {
             $this->$object->$objectkey = $value;
             return true;

lib/Horde/Http/Exception.php

@@ -1,6 +1,7 @@
 <?php
+
 /**
- * Copyright 2007-2017 Horde LLC (http://www.horde.org/)
+ * Copyright 2007-2026 Horde LLC (http://www.horde.org/)
  *
  * See the enclosed file LICENSE for license information (BSD). If you
  * did not receive this file, see http://www.horde.org/licenses/bsd.
@@ -20,6 +21,4 @@
  * @license   http://www.horde.org/licenses/bsd BSD
  * @package   Http
  */
-class Horde_Http_Exception extends Horde_Exception_Wrapped
-{
-}
+class Horde_Http_Exception extends Horde_Exception_Wrapped {}

lib/Horde/Http/Request/Base.php

@@ -1,6 +1,7 @@
 <?php
+
 /**
- * Copyright 2007-2017 Horde LLC (http://www.horde.org/)
+ * Copyright 2007-2026 Horde LLC (http://www.horde.org/)
  *
  * See the enclosed file LICENSE for license information (BSD). If you
  * did not receive this file, see http://www.horde.org/licenses/bsd.
@@ -49,29 +50,29 @@ abstract class Horde_Http_Request_Base
      * Request headers
      * @var array
      */
-    protected $_headers = array();
+    protected $_headers = [];
 
     /**
      * @var array
      */
-    protected $_options = array();
+    protected $_options = [];
 
     /**
      * Constructor
      */
-    public function __construct($options = array())
+    public function __construct($options = [])
     {
         $this->setOptions($options);
     }
 
-    public function setOptions($options = array())
+    public function setOptions($options = [])
     {
         $this->_options = array_merge($this->getDefaultOptions(), $options);
     }
 
     public function getDefaultOptions()
     {
-        return array(
+        return [
             'uri' => null,
             'method' => 'GET',
             'data' => null,
@@ -88,7 +89,7 @@ public function getDefaultOptions()
             'timeout' => 5,
             'userAgent' => str_replace(' @' . 'version@', '', 'Horde_Http @version@'),
             'verifyPeer' => true,
-        );
+        ];
     }
 
     /**
@@ -108,11 +109,11 @@ abstract public function send();
     public function __get($name)
     {
         switch ($name) {
-        case 'headers':
-            return $this->_headers;
+            case 'headers':
+                return $this->_headers;
         }
 
-        return isset($this->_options[$name]) ? $this->_options[$name] : null;
+        return $this->_options[$name] ?? null;
     }
 
     /**
@@ -124,9 +125,9 @@ public function __get($name)
     public function __set($name, $value)
     {
         switch ($name) {
-        case 'headers':
-            $this->setHeaders($value);
-            break;
+            case 'headers':
+                $this->setHeaders($value);
+                break;
         }
 
         $this->_options[$name] = $value;
@@ -141,7 +142,7 @@ public function __set($name, $value)
     public function setHeaders($headers, $value = null)
     {
         if (!is_array($headers)) {
-            $headers = array($headers => $value);
+            $headers = [$headers => $value];
         }
 
         foreach ($headers as $header => $value) {
@@ -157,6 +158,6 @@ public function setHeaders($headers, $value = null)
      */
     public function getHeader($header)
     {
-        return isset($this->_headers[$header]) ? $this->_headers[$header] : null;
+        return $this->_headers[$header] ?? null;
     }
 }

lib/Horde/Http/Request/Curl.php

@@ -1,6 +1,7 @@
 <?php
+
 /**
- * Copyright 2007-2017 Horde LLC (http://www.horde.org/)
+ * Copyright 2007-2026 Horde LLC (http://www.horde.org/)
  *
  * See the enclosed file LICENSE for license information (BSD). If you
  * did not receive this file, see http://www.horde.org/licenses/bsd.
@@ -28,20 +29,20 @@ class Horde_Http_Request_Curl extends Horde_Http_Request_Base
      *
      * @var array
      */
-    protected $_httpAuthSchemes = array(
+    protected $_httpAuthSchemes = [
         Horde_Http::AUTH_ANY => CURLAUTH_ANY,
         Horde_Http::AUTH_BASIC => CURLAUTH_BASIC,
         Horde_Http::AUTH_DIGEST => CURLAUTH_DIGEST,
         Horde_Http::AUTH_GSSNEGOTIATE => CURLAUTH_GSSNEGOTIATE,
         Horde_Http::AUTH_NTLM => CURLAUTH_NTLM,
-    );
+    ];
 
     /**
      * Constructor
      *
      * @throws Horde_Http_Exception
      */
-    public function __construct($args = array())
+    public function __construct($args = [])
     {
         if (!extension_loaded('curl')) {
             throw new Horde_Http_Exception('The curl extension is not installed. See http://php.net/curl.installation');
@@ -59,7 +60,7 @@ public function __construct($args = array())
     public function send()
     {
         $curl = curl_init();
-        curl_setopt($curl, CURLOPT_URL, (string)$this->uri);
+        curl_setopt($curl, CURLOPT_URL, (string) $this->uri);
         curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
         curl_setopt($curl, CURLOPT_HEADER, true);
         curl_setopt($curl, CURLOPT_CUSTOMREQUEST, $this->method);
@@ -102,7 +103,7 @@ public function send()
             }
             if ($this->proxyType == Horde_Http::PROXY_SOCKS5) {
                 curl_setopt($curl, CURLOPT_PROXYTYPE, CURLPROXY_SOCKS5);
-            } else if ($this->proxyType != Horde_Http::PROXY_HTTP) {
+            } elseif ($this->proxyType != Horde_Http::PROXY_HTTP) {
                 throw new Horde_Http_Exception(sprintf('Proxy type %s not supported by this request type!', $this->proxyType));
             }
         }
@@ -114,7 +115,7 @@ public function send()
         }
 
         // Concatenate the headers
-        $hdr = array();
+        $hdr = [];
         $headers = $this->headers;
         if (empty($headers['Expect'])) {
             $headers['Expect'] = '';
@@ -130,7 +131,7 @@ public function send()
             throw new Horde_Http_Exception(curl_error($curl), curl_errno($curl));
         }
         $info = curl_getinfo($curl);
-        return new Horde_Http_Response_Curl((string)$this->uri, $result, $info);
+        return new Horde_Http_Response_Curl((string) $this->uri, $result, $info);
     }
 
     /**

lib/Horde/Http/Request/Factory.php

@@ -1,6 +1,7 @@
 <?php
+
 /**
- * Copyright 2007-2017 Horde LLC (http://www.horde.org/)
+ * Copyright 2007-2026 Horde LLC (http://www.horde.org/)
  *
  * See the enclosed file LICENSE for license information (BSD). If you
  * did not receive this file, see http://www.horde.org/licenses/bsd.