Merged
Conversation
TDannhauer
approved these changes
Apr 18, 2026
Contributor
TDannhauer
left a comment
There was a problem hiding this comment.
fine for me. less duplicate, slightly different code
ralflang
added a commit
that referenced
this pull request
Apr 18, 2026
Release version 1.0.0-beta2 Merge pull request #1 from horde/refactor/from-core chore: Exchange template dependencies for real dependencies docs: Clarify why we did not factor base64url into horde/util docs: Add documentation on usage, upgrading, todos/gaps test: Cover JWT with unit tests feat: Generalize the JWT code from horde/core and horde/components chore: Scaffold library
- Implement generic signatures not restricted to use cases - Implement missing signers and verifiers - Generalize token handling
This is partially inherited from horde/core but also many new tests
Drop outdated CHANGES file from horde skeleton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is our new JWT library which we will need for Oauth2, OpenID Connect, "Federated Login", gmail integration in imp, modern social media apis, github integration etc etc.
It is a more complete version of code we already had in horde/components and horde/core and our first stepping stone towards truely modern features in Horde apps.