fix: recover from unencoded ':' in display-name (lenient mode)#15
Open
Fneufneu wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Open
fix: recover from unencoded ':' in display-name (lenient mode)#15Fneufneu wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Fneufneu wants to merge 1 commit intohorde:FRAMEWORK_6_0from
Conversation
RFC 5322 disallows ':' in an unquoted phrase, but mailers such as AlumnForce/Swift produce name-addr headers like "ACME : The professional network <addr@host>" In lenient/non-strict mode, the parser raised an internal "Error when parsing group" and silently dropped the address. It now recovers when a '<' is present before the next ',' or ';' and returns the mailbox with the full original text as the personal part. Strict mode still rejects such input. Co-Authored-By: Claude Opus 4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Claude proposed a much cleaner fix and tests than I would have. Feel free to close this PR if that's a problem or if you prefer a different approach.
RFC 5322 disallows ':' in an unquoted phrase, but mailers such as AlumnForce/Swift produce name-addr headers like
"ACME : The professional network addr@host"
In lenient/non-strict mode, the parser raised an internal "Error when parsing group" and silently dropped the address. It now recovers when a '<' is present before the next ',' or ';' and returns the mailbox with the full original text as the personal part. Strict mode still rejects such input.
Co-Authored-By: Claude Opus 4.7