Fix new line conversion corner case#2
Merged
ralflang merged 3 commits intohorde:fix/issue_2_new_line_conversion_corner_casefrom Apr 2, 2026
Merged
Conversation
yunosh
requested changes
Nov 14, 2022
bsod85
force-pushed
the
fix_new_line_conversion_corner_case
branch
from
af2f761 to
4119618
Compare
bsod85
commented
Apr 7, 2025
|
|
||
| public function testUnixStyleNewLineSubstitution() | ||
| { | ||
| $test = str_repeat("A\r\n", 4000); |
Contributor
Author
There was a problem hiding this comment.
this test string needs to be bigger than a stream bucket and the carriage return needs to be at the end of a bucket
Member
|
Thank you @bsod85 for this excellent bug fix and your patience over the past 3+ years! The original 2013 fix for Bug #12673 tracked the TARGET EOL's first character but needed to track the SOURCE EOL split. We've redirected your changes to a feature branch fix/eol-crlf-bucket-boundary. This will be merged to the production FRAMEWORK_6_0 branch shortly. |
Member
|
Accepting into a feature branch which includes your changes plus minor modernizations. Will merge to FRAMEWORK_6_0 after final review. |
ralflang
changed the base branch from
FRAMEWORK_6_0
to
fix/issue_2_new_line_conversion_corner_case
Contributor
Author
|
Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.