Improve login.php

[amulet1]

The templates/login.inc includes redesign that removed most of hard-coded things when rendering login_parms. Unfortunately, those changes are essentially lost: compare foreach($loginparams...) loops in login.inc and in the current login.php.

Many things are now hard-coded again. And no longer used login.inc is still present.

One notable issue is support for 'extra' (optional attributes for the fields) parameter. The second factor field (used by Tessera module) expected to have autocomplete="one-time-code", but this is now ignored.

        if ($this->secondFactorSupported()) {
            $loginparams['horde_secondfactor'] = [
                'label' => _("Second Factor"),
                'type'  => $this->secondFactorMode === self::SECOND_FACTOR_SHOWCODE ? 'text' : 'password',
                'extra' => ['autocomplete' => 'one-time-code'],
            ];
        }

Hopefully the code in login.php can be reworked to re-introduce things that were improved/added/fixed long ago.

[ralflang]

I will test with tessera later today.