feat/migrate netdns2#50
Merged
TDannhauer merged 4 commits intoFRAMEWORK_6_0from Mar 13, 2026
Merged
Conversation
Member
ralflang
commented
Mar 13, 2026
ralflang
commented
- feat: Implement Login Parity Integration Test
- fix(auth): correct secondFactorAPI casing to secondFactorApi
- chore(deps): remove unused pear/console_table from suggests
- feat: Drop PEAR dependencies
Implement a parity test between modern and old-style login endpoints. Requires a full setup with an actual auth backend. Uses hordectl to inject users from configuration variables.
Minor consistency fix - method name was secondFactorAPI (uppercase) but should be secondFactorApi (lowercase) to match declaration in Login class.
Package is declared but never used in codebase. No files import or reference Console_Table class.
Replace pear/net_dns2 with mikepultz/netdns2 Drop console_getopt and console_color2 Drop file_fstab Drop Math_BigInt because we actually use ext-bcmath natively Update test.php to not mislead users
TDannhauer
approved these changes
Mar 13, 2026
ralflang
added a commit
that referenced
this pull request
Mar 16, 2026
Release version 6.0.0-beta5 feat(admin-api): New REST API for administrative operations Update horde dependencies to include dev-FRAMEWORK_6_0 Merge pull request #50 from horde/feat/migrate-netdns2 feat: Drop PEAR dependencies chore(deps): remove unused pear/console_table from suggests fix(auth): correct secondFactorAPI casing to secondFactorApi feat: Implement Login Parity Integration Test fix(auth): correct secondFactorAPI casing to secondFactorApi feat: Implement Login Parity Integration Test fix: Refactor second factor validation to rely on Login::secondFactorApi() feat: Improve rendering of topbar and login screen feat(auth): add config options for Basic and Minimal view selection docs(registry): document resolve_hostnames performance setting feat(auth): add config options for Basic and Minimal view selection chore(gitignore): Make sure we never commit the jwt secret key feat: Responsive topbar and login.php amendments for responsive passwd tool style: topbar.js indenting and whitespace issues, wording feat: Add a small collapse delay to topbar to make it more accessible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.