Skip to content

refactor: Convert many helper files from PrototypeJS to vanilla JS #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ralflang wants to merge 5 commits into
base: FRAMEWORK_6_0
Choose a base branch
from
Open

refactor: Convert many helper files from PrototypeJS to vanilla JS #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6eb614a
refactor: Convert many helper files from PrototypeJS to vanilla JS
ralflang Apr 12, 2026
f97a3a1
fix(js): restore $H() cache for compatibility with non-migrated consu…
ralflang Apr 19, 2026
77759cc
refactor(js): Revert event emitters back from dispatchEvent to fire()
ralflang Apr 20, 2026
48bb7ad
refactor(js): De-prototypejs the prefs scripts
ralflang Apr 20, 2026
939521d
refactor: Accept Horde\Util\Variables in most places which accept Hor…
ralflang Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
406 changes: 193 additions & 213 deletions js/autocomplete.js
View file
Open in desktop

Large diffs are not rendered by default.

107 changes: 56 additions & 51 deletions js/contacts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,38 +14,38 @@ var ImpContacts = {

selectedAddresses: function()
{
return $('selected_addresses').select('[value]');
return Array.from(document.getElementById('selected_addresses').querySelectorAll('[value]'));
},

addAddress: function(f)
{
var df = document.createDocumentFragment(),
sa = this.selectedAddresses(),
sr = $('search_results'),
sel = $F(sr);
sr = document.getElementById('search_results'),
sel = Array.from(sr.selectedOptions).map(function(o) { return o.value; });

if (!sel.size()) {
if (!sel.length) {
HordeCore.notify(this.text.select, 'horde.warning');
return;
}

sel.each(function(s) {
if (!sa.any(function(j) {
return (j.readAttribute('value') == s) &&
(j.retrieve('header') == f);
sel.forEach(function(s) {
if (!sa.some(function(j) {
return (j.getAttribute('value') == s) &&
(j._header == f);
})) {
df.appendChild(
new Element('OPTION', { value: s })
.store('header', f)
.insert(
new Element('EM').insert(this.text.rcpt[f] + ': ')
)
.insert(s.escapeHTML())
);
var opt = document.createElement('OPTION');
opt.value = s;
opt._header = f;
var em = document.createElement('EM');
em.textContent = this.text.rcpt[f] + ': ';
opt.appendChild(em);
opt.appendChild(document.createTextNode(s));
df.appendChild(opt);
}
}, this);

$('selected_addresses').appendChild(df);
document.getElementById('selected_addresses').appendChild(df);
},

updateMessage: function()
Expand All @@ -59,19 +59,19 @@ var ImpContacts = {
return;
}

if (!sa.size()) {
if (!sa.length) {
HordeCore.notify(this.text.no_contacts_selected, 'horde.warning');
return;
}

sa.each(function(s) {
var field = s.retrieve('header');
sa.forEach(function(s) {
var field = s._header;

if (Object.isUndefined(addr[field])) {
if (typeof addr[field] === 'undefined') {
addr[field] = [];
}

addr[field].push(s.readAttribute('value'));
addr[field].push(s.getAttribute('value'));
});

$(parent.opener.document).fire('ImpContacts:update', addr);
Expand All @@ -80,7 +80,7 @@ var ImpContacts = {

removeAddress: function()
{
$('selected_addresses').childElements().each(function(o) {
Array.from(document.getElementById('selected_addresses').children).forEach(function(o) {
if (o.selected) {
o.remove();
}
Expand All @@ -89,21 +89,22 @@ var ImpContacts = {

contactsSearch: function()
{
var sr = $('search_results');
var sr = document.getElementById('search_results');

sr.select('[value]').invoke('remove');
sr.childElements().invoke('hide');
sr.appendChild(
new Element('OPTION', { disabled: true, value: "" })
.insert(this.text.searching)
);
Array.from(sr.querySelectorAll('[value]')).forEach(function(o) { o.remove(); });
Array.from(sr.children).forEach(function(o) { o.hidden = true; });
var opt = document.createElement('OPTION');
opt.disabled = true;
opt.value = "";
opt.textContent = this.text.searching;
sr.appendChild(opt);

HordeCore.doAction('contactsSearch', {
search: this.searchGhost.hasinput ? $F('search') : '',
source: $F('source')
search: this.searchGhost.hasinput ? document.getElementById('search').value : '',
source: document.getElementById('source').value
}, {
callback: function(r) {
sr.select(':not([value])').invoke('show');
Array.from(sr.querySelectorAll(':not([value])')).forEach(function(o) { o.hidden = false; });
this.updateResults(r.results);
}.bind(this)
});
Expand All @@ -112,18 +113,18 @@ var ImpContacts = {
updateResults: function(r)
{
var df = document.createDocumentFragment(),
sr = $('search_results');
sr = document.getElementById('search_results');

r.each(function(addr) {
df.appendChild(
new Element('OPTION', { value: addr })
.insert(addr.escapeHTML())
);
r.forEach(function(addr) {
var opt = document.createElement('OPTION');
opt.value = addr;
opt.textContent = addr;
df.appendChild(opt);
});

sr.select('[value]').invoke('remove');
Array.from(sr.querySelectorAll('[value]')).forEach(function(o) { o.remove(); });

if (r.size()) {
if (r.length) {
sr.appendChild(df);
}
},
Expand All @@ -132,7 +133,7 @@ var ImpContacts = {
{
window.resizeBy(
0,
Math.max(0, document.body.clientHeight - document.viewport.getHeight())
Math.max(0, document.body.clientHeight - document.documentElement.clientHeight)
);
},

Expand All @@ -141,7 +142,7 @@ var ImpContacts = {
HordeCore.initHandler('click');
HordeCore.initHandler('dblclick');

$('contacts').observe('FormGhost:submit', function(e) {
document.getElementById('contacts').addEventListener('FormGhost:submit', function(e) {
if (this.searchGhost.hasinput) {
this.contactsSearch();
}
Expand All @@ -154,12 +155,14 @@ var ImpContacts = {

this.searchGhost = new FormGhost('search');

this.resize.bind(this).delay(0.1);
setTimeout(this.resize.bind(this), 100);
},

clickHandler: function(e)
{
switch (e.element().readAttribute('id')) {
var id = e.target.id || (e.target.closest('[id]') || {}).id;

switch (id) {
case 'btn_add_bcc':
this.addAddress('bcc');
break;
Expand All @@ -174,7 +177,7 @@ var ImpContacts = {

case 'btn_cancel':
window.close();
e.memo.hordecore_stop = true;
e.detail.hordecore_stop = true;
break;

case 'btn_clear':
Expand All @@ -186,7 +189,7 @@ var ImpContacts = {
break;

case 'btn_search_all':
$('search').value = '';
document.getElementById('search').value = '';
this.contactsSearch();
break;

Expand All @@ -198,7 +201,9 @@ var ImpContacts = {

dblclickHandler: function(e)
{
switch (e.element().readAttribute('id')) {
var id = e.target.id || (e.target.closest('[id]') || {}).id;

switch (id) {
case 'search_results':
this.addAddress('to');
break;
Expand All @@ -211,6 +216,6 @@ var ImpContacts = {

};

document.observe('dom:loaded', ImpContacts.onDomLoad.bind(ImpContacts));
document.observe('HordeCore:click', ImpContacts.clickHandler.bindAsEventListener(ImpContacts));
document.observe('HordeCore:dblclick', ImpContacts.dblclickHandler.bindAsEventListener(ImpContacts));
document.addEventListener('DOMContentLoaded', ImpContacts.onDomLoad.bind(ImpContacts));
document.addEventListener('HordeCore:click', ImpContacts.clickHandler.bind(ImpContacts));
document.addEventListener('HordeCore:dblclick', ImpContacts.dblclickHandler.bind(ImpContacts));
82 changes: 40 additions & 42 deletions js/draghandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
* DragHandler library for use with prototypejs.
* DragHandler library.
*
* @author Michael Slusarz <slusarz@horde.org>
* @copyright 2013-2015 Horde LLC
Expand All @@ -19,93 +19,91 @@ var DragHandler = {
{
return (e.dataTransfer &&
e.dataTransfer.types &&
$A(e.dataTransfer.types).include('Files') &&
Array.from(e.dataTransfer.types).indexOf('Files') !== -1 &&
((e.type != 'drop') || e.dataTransfer.files.length));
},

handleObserve: function(e)
{
if (this.dropelt &&
(e.dataTransfer ||
(e.memo && e.memo.dataTransfer) ||
this.dropelt.visible())) {
if (Prototype.Browser.IE &&
!(("onpropertychange" in document) && (!!window.matchMedia))) {
// IE 9 supports drag/drop, but not dataTransfer.files
} else {
switch (e.type) {
case 'dragleave':
this.handleLeave();
break;

case 'dragover':
this.handleOver(e);
break;

case 'drop':
this.handleDrop(e);
break;
}
(e.detail && e.detail.dataTransfer) ||
!this.dropelt.hidden)) {
switch (e.type) {
case 'dragleave':
this.handleLeave();
break;

case 'dragover':
this.handleOver(e);
break;

case 'drop':
this.handleDrop(e);
break;
}
}
},

handleDrop: function(e)
{
this.leave = true;
this.hide();
this.hide(); // eslint-disable-line horde/no-prototype-methods -- DragHandler.hide()

if (this.isFileDrag(e)) {
if (this.dropelt.hasClassName(this.hoverclass)) {
if (this.dropelt.classList.contains(this.hoverclass)) {
this.dropelt.fire('DragHandler:drop', e.dataTransfer.files);
}
e.stop();
} else if (!e.findElement('TEXTAREA') && !e.findElement('INPUT')) {
e.stop();
e.preventDefault();
} else if (!e.target.closest('TEXTAREA') && !e.target.closest('INPUT')) {
e.preventDefault();
}
},

hide: function()
{
if (this.leave) {
this.dropelt.hide();
this.droptarget.show();
this.dropelt.hidden = true;
this.droptarget.hidden = false;
this.leave = false;
}
},

handleLeave: function()
{
clearTimeout(this.to);
this.to = this.hide.bind(this).delay(0.25);
this.to = setTimeout(this.hide.bind(this), 250);
this.leave = true;
},

handleOver: function(e)
{
var file = this.isFileDrag(e);

if (file && !this.dropelt.visible()) {
this.dropelt.clonePosition(this.droptarget).show();
this.droptarget.hide();
if (file && this.dropelt.hidden) {
// Position dropelt over droptarget
var rect = this.droptarget.getBoundingClientRect();
this.dropelt.style.position = 'absolute';
this.dropelt.style.left = rect.left + 'px';
this.dropelt.style.top = rect.top + 'px';
this.dropelt.style.width = rect.width + 'px';
this.dropelt.style.height = rect.height + 'px';
this.dropelt.hidden = false;
this.droptarget.hidden = true;
}

this.leave = false;

if (file && (e.target == this.dropelt)) {
this.dropelt.addClassName(this.hoverclass);
e.stop();
this.dropelt.classList.add(this.hoverclass);
e.preventDefault();
} else {
this.dropelt.removeClassName(this.hoverclass);
if (Prototype.Browser.IE ||
Prototype.Browser.Gecko) {
e.stop();
}
this.dropelt.classList.remove(this.hoverclass);
}
}

};

document.observe('dragleave', DragHandler.handleObserve.bindAsEventListener(DragHandler));
document.observe('dragover', DragHandler.handleObserve.bindAsEventListener(DragHandler));
document.observe('drop', DragHandler.handleObserve.bindAsEventListener(DragHandler));
document.addEventListener('dragleave', DragHandler.handleObserve.bind(DragHandler));
document.addEventListener('dragover', DragHandler.handleObserve.bind(DragHandler));
document.addEventListener('drop', DragHandler.handleObserve.bind(DragHandler));
Loading
Loading