Refactor download URL extraction logic#38
Open
TDannhauer wants to merge 1 commit intoFRAMEWORK_6_0from
Open
Conversation
Updated download URL handling to support various formats and ensure valid URLs are used.
Contributor
Author
|
fixes together with PR horde/base#83 issue #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix smartmobile attachment links to open/download reliably on mobile by avoiding AJAX navigation and handling non-string
download_urlpayloads.Context / Problem
In smartmobile mode, opening attachments (for example PDFs) could fail with blank/error pages.
Root cause: attachment links were sometimes built from a non-string
download_urlvalue (serialized object), producing invalid URLs such as[object Object]. Also, attachment requests should bypass jQuery Mobile AJAX navigation for binary responses.Changes
vendor/horde/imp/js/smartmobile.jsIn
showAttachments():rel: 'external'data-ajax: 'false'v.download_urlwhen it is a valid string.hreffrom existingv.downloadHTML as fallback.Why this approach
v.downloadkeeps compatibility with payload variants where URL objects are serialized unexpectedly.Behavioral Impact
download_urlis not a string./imp/[object Object].Test Plan
[object Object]in Network tab.